356 lines
16 KiB
TypeScript
356 lines
16 KiB
TypeScript
import { readFile } from "fs/promises"
|
|
import path from "path"
|
|
import { describe, expect, test } from "bun:test"
|
|
|
|
async function readRepoFile(relativePath: string): Promise<string> {
|
|
return readFile(path.join(process.cwd(), relativePath), "utf8")
|
|
}
|
|
|
|
describe("ce:work review contract", () => {
|
|
test("requires code review before shipping", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work/SKILL.md")
|
|
// Review content extracted to references/shipping-workflow.md
|
|
const shipping = await readRepoFile("plugins/compound-engineering/skills/ce-work/references/shipping-workflow.md")
|
|
|
|
// SKILL.md should not contain extracted content
|
|
expect(content).not.toContain("2. **Code Review**")
|
|
expect(content).not.toContain("Consider Code Review")
|
|
expect(content).not.toContain("Code Review** (Optional)")
|
|
|
|
// Phase 3 has a mandatory code review step in the reference file
|
|
expect(shipping).toContain("2. **Code Review**")
|
|
|
|
// Two-tier rubric in reference file
|
|
expect(shipping).toContain("**Tier 1: Inline self-review**")
|
|
expect(shipping).toContain("**Tier 2: Full review (default)**")
|
|
expect(shipping).toContain("ce:review")
|
|
expect(shipping).toContain("mode:autofix")
|
|
|
|
// Quality checklist includes review
|
|
expect(shipping).toContain("Code review completed (inline self-review or full `ce:review`)")
|
|
})
|
|
|
|
test("delegates commit and PR to dedicated skills", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work/SKILL.md")
|
|
// Commit/PR delegation content extracted to references/shipping-workflow.md
|
|
const shipping = await readRepoFile("plugins/compound-engineering/skills/ce-work/references/shipping-workflow.md")
|
|
|
|
expect(shipping).toContain("`git-commit-push-pr` skill")
|
|
expect(shipping).toContain("`git-commit` skill")
|
|
|
|
// Should not contain inline PR templates or attribution placeholders
|
|
expect(content).not.toContain("gh pr create")
|
|
expect(content).not.toContain("[HARNESS_URL]")
|
|
})
|
|
|
|
test("ce:work-beta mirrors review and commit delegation", async () => {
|
|
const beta = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
// Review/commit content extracted to references/shipping-workflow.md
|
|
const shipping = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/references/shipping-workflow.md")
|
|
|
|
// Extracted content in reference file
|
|
expect(shipping).toContain("2. **Code Review**")
|
|
expect(shipping).toContain("`git-commit-push-pr` skill")
|
|
expect(shipping).toContain("`git-commit` skill")
|
|
|
|
// Negative assertions stay on SKILL.md
|
|
expect(beta).not.toContain("Consider Code Review")
|
|
expect(beta).not.toContain("gh pr create")
|
|
})
|
|
|
|
test("includes per-task testing deliberation in execution loop", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work/SKILL.md")
|
|
|
|
// Testing deliberation exists in the execution loop
|
|
expect(content).toContain("Assess testing coverage")
|
|
|
|
// Deliberation is between "Run tests after changes" and "Mark task as completed"
|
|
const runTestsIdx = content.indexOf("Run tests after changes")
|
|
const assessIdx = content.indexOf("Assess testing coverage")
|
|
const markDoneIdx = content.indexOf("Mark task as completed")
|
|
expect(runTestsIdx).toBeLessThan(assessIdx)
|
|
expect(assessIdx).toBeLessThan(markDoneIdx)
|
|
})
|
|
|
|
test("quality checklist says 'Testing addressed' not 'Tests pass'", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work/SKILL.md")
|
|
// Quality checklist extracted to references/shipping-workflow.md
|
|
const shipping = await readRepoFile("plugins/compound-engineering/skills/ce-work/references/shipping-workflow.md")
|
|
|
|
// New language present in reference file
|
|
expect(shipping).toContain("Testing addressed")
|
|
|
|
// Old language fully removed from both
|
|
expect(content).not.toContain("Tests pass (run project's test command)")
|
|
expect(content).not.toContain("- All tests pass")
|
|
expect(shipping).not.toContain("Tests pass (run project's test command)")
|
|
})
|
|
|
|
test("ce:work-beta mirrors testing deliberation and checklist changes", async () => {
|
|
const beta = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
// Checklist extracted to references/shipping-workflow.md
|
|
const shipping = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/references/shipping-workflow.md")
|
|
|
|
// Testing deliberation stays in SKILL.md (Phase 2 content)
|
|
expect(beta).toContain("Assess testing coverage")
|
|
|
|
// New checklist language in reference file
|
|
expect(shipping).toContain("Testing addressed")
|
|
|
|
// Old language removed from both
|
|
expect(beta).not.toContain("Tests pass (run project's test command)")
|
|
expect(beta).not.toContain("- All tests pass")
|
|
expect(shipping).not.toContain("Tests pass (run project's test command)")
|
|
})
|
|
|
|
test("SKILL.md stub points to shipping-workflow reference", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work/SKILL.md")
|
|
|
|
// Stub references the shipping-workflow file
|
|
expect(content).toContain("`references/shipping-workflow.md`")
|
|
|
|
// Extracted content is not in SKILL.md
|
|
expect(content).not.toContain("2. **Code Review**")
|
|
expect(content).not.toContain("## Quality Checklist")
|
|
expect(content).not.toContain("## Code Review Tiers")
|
|
})
|
|
|
|
test("ce:work-beta SKILL.md stub points to shipping-workflow reference", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
|
|
// Stub references the shipping-workflow file
|
|
expect(content).toContain("`references/shipping-workflow.md`")
|
|
|
|
// Extracted content is not in SKILL.md
|
|
expect(content).not.toContain("2. **Code Review**")
|
|
expect(content).not.toContain("## Quality Checklist")
|
|
expect(content).not.toContain("## Code Review Tiers")
|
|
})
|
|
|
|
test("ce:work remains the stable non-delegating surface", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work/SKILL.md")
|
|
|
|
expect(content).not.toContain("## Argument Parsing")
|
|
expect(content).not.toContain("## Codex Delegation Mode")
|
|
expect(content).not.toContain("delegate:codex")
|
|
})
|
|
})
|
|
|
|
describe("ce:work-beta codex delegation contract", () => {
|
|
test("has argument parsing with delegate tokens", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
|
|
// Argument parsing section exists with delegation tokens
|
|
expect(content).toContain("## Argument Parsing")
|
|
expect(content).toContain("`delegate:codex`")
|
|
expect(content).toContain("`delegate:local`")
|
|
|
|
// Resolution chain present
|
|
expect(content).toContain("### Settings Resolution Chain")
|
|
expect(content).toContain("work_delegate")
|
|
expect(content).toContain("config.local.yaml")
|
|
})
|
|
|
|
test("argument-hint includes delegate:codex for discoverability", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
|
|
expect(content).toContain("argument-hint:")
|
|
expect(content).toContain("delegate:codex")
|
|
})
|
|
|
|
test("remains manual-invocation beta during rollout", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
|
|
expect(content).toContain("disable-model-invocation: true")
|
|
expect(content).toContain("Invoke `ce:work-beta` manually")
|
|
expect(content).toContain("planning and workflow handoffs remain pointed at stable `ce:work`")
|
|
})
|
|
|
|
test("SKILL.md has delegation routing stub pointing to reference", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
|
|
expect(content).toContain("## Codex Delegation Mode")
|
|
expect(content).toContain("references/codex-delegation-workflow.md")
|
|
// Delegation details are NOT in SKILL.md body — they're in the reference
|
|
expect(content).not.toContain("### Pre-Delegation Checks")
|
|
expect(content).not.toContain("### Prompt Template")
|
|
expect(content).not.toContain("### Execution Loop")
|
|
})
|
|
|
|
test("delegation routing gate in Phase 1 Step 4", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
|
|
const gateIdx = content.indexOf("Delegation routing gate")
|
|
const strategyTableIdx = content.indexOf("| **Inline**")
|
|
expect(gateIdx).toBeGreaterThan(0)
|
|
expect(gateIdx).toBeLessThan(strategyTableIdx)
|
|
expect(content).toContain("Codex delegation requires a plan file")
|
|
})
|
|
|
|
test("delegation branches in Phase 2 task loop", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
|
|
expect(content).toContain("If delegation_active: branch to the Codex Delegation Execution Loop")
|
|
})
|
|
|
|
test("delegation reference has all required sections", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/references/codex-delegation-workflow.md")
|
|
|
|
// Pre-delegation checks
|
|
expect(content).toContain("## Pre-Delegation Checks")
|
|
expect(content).toContain("Platform Gate")
|
|
expect(content).toContain("CODEX_SANDBOX")
|
|
expect(content).toContain("command -v codex")
|
|
expect(content).toContain("Consent Flow")
|
|
|
|
// Batching
|
|
expect(content).toContain("## Batching")
|
|
|
|
// Prompt template
|
|
expect(content).toContain("## Prompt Template")
|
|
expect(content).toContain("<task>")
|
|
expect(content).toContain("<constraints>")
|
|
expect(content).toContain("<output_contract>")
|
|
expect(content).toContain("the orchestrator will not re-run verification independently")
|
|
|
|
// Result schema and execution loop
|
|
expect(content).toContain("## Result Schema")
|
|
expect(content).toContain("## Execution Loop")
|
|
expect(content).toContain("codex exec")
|
|
|
|
// Circuit breaker
|
|
expect(content).toContain("consecutive_failures")
|
|
expect(content).toContain("3 consecutive failures")
|
|
|
|
// Rollback safety
|
|
expect(content).toContain("git diff --quiet HEAD")
|
|
expect(content).toContain("git checkout -- .")
|
|
expect(content).toContain("Do NOT use bare `git clean -fd` without path arguments")
|
|
|
|
// Mixed-model attribution
|
|
expect(content).toContain("## Mixed-Model Attribution")
|
|
})
|
|
|
|
test("delegation reference has decision prompts for ask mode", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/references/codex-delegation-workflow.md")
|
|
|
|
expect(content).toContain("## Delegation Decision")
|
|
expect(content).toContain("work_delegate_decision")
|
|
expect(content).toContain("Execute with Claude Code instead")
|
|
expect(content).toContain("Delegate to Codex anyway")
|
|
expect(content).toContain("the cost of delegating outweighs having Claude Code do them")
|
|
})
|
|
|
|
test("settings resolution includes delegation decision setting", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
|
|
expect(content).toContain("work_delegate_decision")
|
|
expect(content).toContain("`auto`")
|
|
expect(content).toContain("`ask`")
|
|
})
|
|
|
|
test("has frontend design guidance ported from beta", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
|
|
|
|
expect(content).toContain("**Frontend Design Guidance**")
|
|
expect(content).toContain("`frontend-design` skill")
|
|
})
|
|
})
|
|
|
|
describe("ce:plan remains neutral during ce:work-beta rollout", () => {
|
|
test("removes delegation-specific execution posture guidance", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/SKILL.md")
|
|
|
|
// Old tag removed from execution posture signals
|
|
expect(content).not.toContain("add `Execution target: external-delegate`")
|
|
|
|
// Old tag removed from execution note examples
|
|
expect(content).not.toContain("Execution note: Execution target: external-delegate")
|
|
|
|
// Planner stays neutral instead of teaching beta-only invocation
|
|
expect(content).not.toContain("delegate:codex")
|
|
})
|
|
})
|
|
|
|
describe("ce:brainstorm review contract", () => {
|
|
test("requires document review before handoff", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-brainstorm/SKILL.md")
|
|
|
|
// Phase 3.5 exists and runs document-review
|
|
expect(content).toContain("### Phase 3.5: Document Review")
|
|
expect(content).toContain("`document-review` skill")
|
|
|
|
// Phase 3 and Phase 4 are extracted to references for token optimization
|
|
expect(content).toContain("`references/requirements-capture.md`")
|
|
expect(content).toContain("`references/handoff.md`")
|
|
|
|
// Additional review passes are surfaced contextually (not as a menu fixture) and still
|
|
// route through the document-review skill when requested
|
|
const handoff = await readRepoFile("plugins/compound-engineering/skills/ce-brainstorm/references/handoff.md")
|
|
expect(handoff).toContain("Surface additional document review contextually")
|
|
expect(handoff).toContain("Load the `document-review` skill")
|
|
expect(handoff).not.toContain("**Review and refine**")
|
|
})
|
|
})
|
|
|
|
describe("ce:plan testing contract", () => {
|
|
test("flags blank test scenarios on feature-bearing units as incomplete", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/SKILL.md")
|
|
|
|
// Phase 5.1 review checklist addresses blank test scenarios
|
|
expect(content).toContain("blank or missing test scenarios")
|
|
expect(content).toContain("Test expectation: none")
|
|
|
|
// Template comment mentions the annotation convention
|
|
expect(content).toContain("Test expectation: none -- [reason]")
|
|
})
|
|
})
|
|
|
|
describe("ce:plan review contract", () => {
|
|
test("requires document review after confidence check", async () => {
|
|
// Document review instructions extracted to references/plan-handoff.md
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/references/plan-handoff.md")
|
|
|
|
// Phase 5.3.8 runs document-review before final checks (5.3.9)
|
|
expect(content).toContain("## 5.3.8 Document Review")
|
|
expect(content).toContain("`document-review` skill")
|
|
|
|
// Document review must come before final checks so auto-applied edits are validated
|
|
const docReviewIdx = content.indexOf("5.3.8 Document Review")
|
|
const finalChecksIdx = content.indexOf("5.3.9 Final Checks")
|
|
expect(docReviewIdx).toBeLessThan(finalChecksIdx)
|
|
})
|
|
|
|
test("SKILL.md stub points to plan-handoff reference", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/SKILL.md")
|
|
|
|
// Stub references the handoff file and marks document review as mandatory
|
|
expect(content).toContain("`references/plan-handoff.md`")
|
|
expect(content).toContain("Document review is mandatory")
|
|
})
|
|
|
|
test("uses headless mode in pipeline context", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/references/plan-handoff.md")
|
|
|
|
// Pipeline mode runs document-review headlessly, not skipping it
|
|
expect(content).toContain("document-review` with `mode:headless`")
|
|
expect(content).not.toContain("skip document-review and return control")
|
|
})
|
|
|
|
test("handoff options recommend ce:work after review", async () => {
|
|
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/references/plan-handoff.md")
|
|
|
|
// ce:work is recommended (review already happened)
|
|
expect(content).toContain("**Start `/ce:work`** (recommended) - Begin implementing this plan in the current session")
|
|
|
|
// Additional review passes are surfaced contextually (not as a menu fixture) and still
|
|
// route through the document-review skill when requested
|
|
expect(content).toContain("Surface additional document review contextually")
|
|
expect(content).toContain("Load the `document-review` skill")
|
|
|
|
// No conditional ordering based on plan depth (review already ran)
|
|
expect(content).not.toContain("**Options when document-review is recommended:**")
|
|
expect(content).not.toContain("**Options for Standard or Lightweight plans:**")
|
|
})
|
|
})
|