Files
John Lamb 3bbcf4a2ce
Some checks failed
CI / pr-title (push) Has been cancelled
CI / test (push) Has been cancelled
Release PR / release-pr (push) Has been cancelled
Release PR / publish-cli (push) Has been cancelled
Merge step (j): update tests + legacy-cleanup registries for deleted agents
Fork deleted 9 ce-* reviewer agents in step (c.1) and dropped the ce-dhh-
rails-style skill in step (c.2). Tests and legacy-cleanup registries
needed corresponding updates.

Tests:
- tests/review-skill-contract.test.ts: drop ce-dhh-rails-reviewer,
  ce-kieran-rails-reviewer, and ce-data-migration-expert from persona list
  tests. Remove the data-migration-expert unstructured-format test.
- tests/legacy-cleanup.test.ts: switch the .agent.md copilot-format test
  to use agents that still have ce-* versions (correctness-reviewer,
  maintainability-reviewer) since security-sentinel and performance-oracle
  are gone. Drop the `lint` case from legacy-only cleanup since the fork
  re-introduced ce-lint (Python linter) as a current agent.

Legacy cleanup registries:
- src/utils/legacy-cleanup.ts: add the 9 deleted ce-* agent names to
  STALE_AGENT_NAMES and ce-dhh-rails-style to STALE_SKILL_DIRS so upgrades
  from pre-merge installs sweep the old files.
- src/data/plugin-legacy-artifacts.ts: mirror the additions in the
  compound-engineering plugin's historical artifact lists.

Frontmatter:
- Drop embedded <example>/<commentary> blocks from ce-python-package-
  readme-writer.agent.md and ce-tiangolo-fastapi-reviewer.agent.md
  descriptions. Cowork's plugin validator rejects bare angle-bracket
  tokens; tests/frontmatter.test.ts was failing on these two local agents.

Test state: 944 pass / 9 fail. Remaining 9 failures are pre-existing
detect-project-type.sh monorepo probe tests in ce-polish-beta that were
failing on baseline HEAD before this merge work began. Not introduced
by this merge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 14:12:14 -05:00
..