2 Commits

Author SHA1 Message Date
John Lamb
aabad4a75a Merge step (i): reference sweep — fix stray old-convention refs
Some checks failed
CI / pr-title (push) Has been cancelled
CI / test (push) Has been cancelled
Release PR / release-pr (push) Has been cancelled
Release PR / publish-cli (push) Has been cancelled
Applies triage doc 022. Most of the sweep was no-op because upstream already
renamed everything in place when we branched from origin/main. Remaining
fixes:

- ce-pr-comments-review/SKILL.md: replace compound-engineering:review:/
  workflow: prefixed agent refs with bare ce-<name> form (self-correction
  from step g where I accidentally used old convention)
- ce-essay-edit/SKILL.md: update /essay-outline reference to /ce-essay-outline

Prose references to generic words ("onboarding", "changelog") are left
alone — they are natural-language uses, not skill references.

Known follow-up: tests/review-skill-contract.test.ts and
tests/legacy-cleanup.test.ts still reference locally-removed agents
(ce-dhh-rails-reviewer, ce-kieran-rails-reviewer, ce-data-migration-expert,
ce-security-sentinel). These will need test updates + registration of
removed names in src/utils/legacy-cleanup.ts and
src/data/plugin-legacy-artifacts.ts — flagged for step (j).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 14:04:22 -05:00
John Lamb
9b690499ab Merge step (f/g/h): retire todo system, retool pr-comments-review, rewrite ce-upstream-merge
Some checks failed
CI / pr-title (push) Has been cancelled
CI / test (push) Has been cancelled
Release PR / release-pr (push) Has been cancelled
Release PR / publish-cli (push) Has been cancelled
Applies triage doc 021 in full. Legacy file-based todo system is gone; the
two local workflows that depended on it are retooled around platform-
native task tracking and ce-code-review-style walkthrough patterns.

Deletions:
- commands/resolve_todo_parallel.md — obsolete; ce-pr-comments-review now
  orchestrates resolution inline
- commands/pr-comments-to-todos.md — replaced by ce-pr-comments-review skill
- skills/ce-upstream-merge/assets/merge-triage-template.md — template now
  lives inline in SKILL.md since decisions live in the task tracker

Retool:
- New skill skills/ce-pr-comments-review/SKILL.md: fetch PR comments,
  pressure-test each via validator agent, walk through with AskUserQuestion
  (Fix now / Clarify / Push back / Skip), dispatch ce-pr-comment-resolver
  for accepted fixes. Uses TaskCreate instead of todos/*.md.

Rewrite:
- skills/ce-upstream-merge/SKILL.md: drops the "create todos in todos/"
  pattern entirely. Phase 2 builds a platform-task decision set instead.
  Phase 3 walks through with AskUserQuestion. Phase 4 splits execution
  into 7 named checkpoints (b-h) so the user can inspect and course-
  correct mid-flight. Adds explicit "hidden conflicts" detection in
  Phase 1 (upstream rename of file local deleted, upstream deletion of
  file local depends on, structural refactors).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 14:01:15 -05:00