john/claude-engineering-plugin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ce-brainstorm): make doc review opt-in in Phase 4 handoff (#633)
Some checks failed
CI / pr-title (push) Has been cancelled
Details
CI / test (push) Has been cancelled
Details
Release PR / release-pr (push) Has been cancelled
Details
Release PR / publish-cli (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Trevin Chow
2026-04-21 16:28:20 -07:00
committed by GitHub
parent 44ce9dd127
commit ff0eee391e
4 changed files with 63 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/pipeline-review-contract.test.ts
View File

@@ -273,22 +273,23 @@ describe("ce:plan remains neutral during ce:work-beta rollout", () => {
})
describe("ce-brainstorm review contract", () => {
test("requires document review before handoff", async () => {
test("exposes document review as an opt-in handoff option", async () => {
const content = await readRepoFile("plugins/compound-engineering/skills/ce-brainstorm/SKILL.md")
const handoff = await readRepoFile("plugins/compound-engineering/skills/ce-brainstorm/references/handoff.md")
// Phase 3.5 exists and runs document-review
expect(content).toContain("### Phase 3.5: Document Review")
expect(content).toContain("`ce-doc-review` skill")
// Document review is no longer a forced Phase 3.5 step. Users opt in from the Phase 4 menu.
expect(content).not.toContain("Phase 3.5")
// Phase 3 and Phase 4 are extracted to references for token optimization
expect(content).toContain("`references/requirements-capture.md`")
expect(content).toContain("`references/handoff.md`")
// Additional review passes are surfaced contextually (not as a menu fixture) and still
// route through the ce-doc-review skill when requested
const handoff = await readRepoFile("plugins/compound-engineering/skills/ce-brainstorm/references/handoff.md")
expect(handoff).toContain("Surface additional document review contextually")
// Phase 4 menu exposes agent review as a first-class option and routes to ce-doc-review
expect(handoff).toContain("Agent review of requirements doc with `ce-doc-review`")
expect(handoff).toContain("Load the `ce-doc-review` skill")
// Subsequent-round residual findings are surfaced as a prose nudge, not a separate menu option
expect(handoff).toContain("Post-review nudge")
expect(handoff).not.toContain("**Review and refine**")
})
})