feat: add ce:review-beta with structured persona pipeline (#348)

tests/review-skill-contract.test.ts

@@ -0,0 +1,93 @@
+import { readFile } from "fs/promises"
+import path from "path"
+import { describe, expect, test } from "bun:test"
+
+async function readRepoFile(relativePath: string): Promise<string> {
+  return readFile(path.join(process.cwd(), relativePath), "utf8")
+}
+
+describe("ce-review-beta contract", () => {
+  test("documents explicit modes and orchestration boundaries", async () => {
+    const content = await readRepoFile("plugins/compound-engineering/skills/ce-review-beta/SKILL.md")
+
+    expect(content).toContain("## Mode Detection")
+    expect(content).toContain("mode:autonomous")
+    expect(content).toContain("mode:report-only")
+    expect(content).toContain(".context/compound-engineering/ce-review-beta/<run-id>/")
+    expect(content).toContain("Do not create residual todos or `.context` artifacts.")
+    expect(content).toContain(
+      "Do not start a mutating review round concurrently with browser testing on the same checkout.",
+    )
+    expect(content).toContain("mode:report-only cannot switch the shared checkout to review a PR target")
+    expect(content).toContain("mode:report-only cannot switch the shared checkout to review another branch")
+    expect(content).toContain("Resolve the base ref from the PR's actual base repository, not by assuming `origin`")
+    expect(content).not.toContain("Which severities should I fix?")
+  })
+
+  test("documents policy-driven routing and residual handoff", async () => {
+    const content = await readRepoFile("plugins/compound-engineering/skills/ce-review-beta/SKILL.md")
+
+    expect(content).toContain("## Action Routing")
+    expect(content).toContain("Only `safe_auto -> review-fixer` enters the in-skill fixer queue automatically.")
+    expect(content).toContain(
+      "Only include `gated_auto` findings in the fixer queue after the user explicitly approves the specific items.",
+    )
+    expect(content).toContain(
+      'If the fixer queue is empty, do not offer "Apply safe_auto fixes" options.',
+    )
+    expect(content).toContain(
+      "In autonomous mode, create durable `todos/` items only for unresolved actionable findings whose final owner is `downstream-resolver`.",
+    )
+    expect(content).toContain("If only advisory outputs remain, create no todos.")
+    expect(content).toContain("**On the resolved review base/default branch:**")
+    expect(content).toContain("git push --set-upstream origin HEAD")
+    expect(content).not.toContain("**On main/master:**")
+  })
+
+  test("keeps findings schema and downstream docs aligned", async () => {
+    const rawSchema = await readRepoFile(
+      "plugins/compound-engineering/skills/ce-review-beta/references/findings-schema.json",
+    )
+    const schema = JSON.parse(rawSchema) as {
+      _meta: { confidence_thresholds: { suppress: string } }
+      properties: {
+        findings: {
+          items: {
+            properties: {
+              autofix_class: { enum: string[] }
+              owner: { enum: string[] }
+              requires_verification: { type: string }
+            }
+            required: string[]
+          }
+        }
+      }
+    }
+
+    expect(schema.properties.findings.items.required).toEqual(
+      expect.arrayContaining(["autofix_class", "owner", "requires_verification"]),
+    )
+    expect(schema.properties.findings.items.properties.autofix_class.enum).toEqual([
+      "safe_auto",
+      "gated_auto",
+      "manual",
+      "advisory",
+    ])
+    expect(schema.properties.findings.items.properties.owner.enum).toEqual([
+      "review-fixer",
+      "downstream-resolver",
+      "human",
+      "release",
+    ])
+    expect(schema.properties.findings.items.properties.requires_verification.type).toBe("boolean")
+    expect(schema._meta.confidence_thresholds.suppress).toContain("0.60")
+
+    const fileTodos = await readRepoFile("plugins/compound-engineering/skills/file-todos/SKILL.md")
+    expect(fileTodos).toContain("/ce:review-beta mode:autonomous")
+    expect(fileTodos).toContain("/resolve-todo-parallel")
+
+    const resolveTodos = await readRepoFile("plugins/compound-engineering/skills/resolve-todo-parallel/SKILL.md")
+    expect(resolveTodos).toContain("ce:review-beta mode:autonomous")
+    expect(resolveTodos).toContain("safe_auto")
+  })
+})