fix: address code review findings for gemini target

- Extract named GeminiMcpServer type (eliminates NonNullable indexing)
- Deep-merge mcpServers in settings.json (preserves existing entries)
- Warn when existing settings.json cannot be parsed
- Add test for uniqueName dedup (agent/skill name collision)
- Add test for TOML triple-quote escaping

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Kieran Klaassen
2026-02-14 20:46:31 -08:00
parent e113d20126
commit d487915f0f
5 changed files with 52 additions and 14 deletions

View File

@@ -1,6 +1,6 @@
import { formatFrontmatter } from "../utils/frontmatter"
import type { ClaudeAgent, ClaudeCommand, ClaudeMcpServer, ClaudePlugin } from "../types/claude"
import type { GeminiBundle, GeminiCommand, GeminiSkill } from "../types/gemini"
import type { GeminiBundle, GeminiCommand, GeminiMcpServer, GeminiSkill } from "../types/gemini"
import type { ClaudeToOpenCodeOptions } from "./claude-to-opencode"
export type ClaudeToGeminiOptions = ClaudeToOpenCodeOptions
@@ -109,12 +109,12 @@ export function transformContentForGemini(body: string): string {
function convertMcpServers(
servers?: Record<string, ClaudeMcpServer>,
): GeminiBundle["mcpServers"] | undefined {
): Record<string, GeminiMcpServer> | undefined {
if (!servers || Object.keys(servers).length === 0) return undefined
const result: NonNullable<GeminiBundle["mcpServers"]> = {}
const result: Record<string, GeminiMcpServer> = {}
for (const [name, server] of Object.entries(servers)) {
const entry: NonNullable<GeminiBundle["mcpServers"]>[string] = {}
const entry: GeminiMcpServer = {}
if (server.command) {
entry.command = server.command
if (server.args && server.args.length > 0) entry.args = server.args