Merge upstream v2.34.0 with FastAPI pivot (v2.35.0)
Incorporate 42 upstream commits while preserving the Ruby/Rails → Python/FastAPI pivot. Each of the 24 conflicting files was individually triaged. Added: tiangolo-fastapi-reviewer, python-package-readme-writer, lint (Python), pr-comments-to-todos, fastapi-style skill, python-package-writer skill. Removed: 3 design agents, ankane-readme-writer, dhh-rails-reviewer, kieran-rails-reviewer, andrew-kane-gem-writer, dhh-rails-style, dspy-ruby. Merged: best-practices-researcher, kieran-python-reviewer, resolve_todo_parallel, file-todos, workflows/review (pressure test), workflows/plan (reviewer names). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -19,6 +19,22 @@ What is broken, missing, or needs improvement? Provide clear context about why t
|
||||
- Email service is missing proper error handling for rate-limit scenarios
|
||||
- Documentation doesn't cover the new authentication flow
|
||||
|
||||
## Assessment (Pressure Test)
|
||||
|
||||
*(For findings from code review or automated agents)*
|
||||
|
||||
| Criterion | Result |
|
||||
|-----------|--------|
|
||||
| **Assessment** | Clear & Correct / Unclear / Likely Incorrect / YAGNI |
|
||||
| **Recommended Action** | Fix now / Clarify / Push back / Skip |
|
||||
| **Verified Code?** | Yes/No - [what was checked] |
|
||||
| **Verified Tests?** | Yes/No - [existing coverage] |
|
||||
| **Verified Usage?** | Yes/No - [how code is used] |
|
||||
| **Prior Decisions?** | Yes/No - [any intentional design] |
|
||||
|
||||
**Technical Justification:**
|
||||
[If pushing back or marking YAGNI, provide specific technical reasoning. Reference codebase constraints, requirements, or trade-offs.]
|
||||
|
||||
## Findings
|
||||
|
||||
Investigation results, root cause analysis, and key discoveries.
|
||||
|
||||
Reference in New Issue
Block a user