Merge upstream v2.34.0 with FastAPI pivot (v2.35.0)

Incorporate 42 upstream commits while preserving the Ruby/Rails → Python/FastAPI
pivot. Each of the 24 conflicting files was individually triaged.

Added: tiangolo-fastapi-reviewer, python-package-readme-writer, lint (Python),
pr-comments-to-todos, fastapi-style skill, python-package-writer skill.

Removed: 3 design agents, ankane-readme-writer, dhh-rails-reviewer,
kieran-rails-reviewer, andrew-kane-gem-writer, dhh-rails-style, dspy-ruby.

Merged: best-practices-researcher, kieran-python-reviewer, resolve_todo_parallel,
file-todos, workflows/review (pressure test), workflows/plan (reviewer names).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
John Lamb
2026-02-16 17:34:54 -06:00
parent 1a3e8e2b58
commit d306c49179
45 changed files with 1533 additions and 8548 deletions

View File

@@ -45,6 +45,7 @@ Each todo is a markdown file with YAML frontmatter and structured sections. Use
**Required sections:**
- **Problem Statement** - What is broken, missing, or needs improvement?
- **Assessment (Pressure Test)** - For code review findings: verification results and engineering judgment
- **Findings** - Investigation results, root cause, key discoveries
- **Proposed Solutions** - Multiple options with pros/cons, effort, risk
- **Recommended Action** - Clear plan (filled during triage)
@@ -56,6 +57,12 @@ Each todo is a markdown file with YAML frontmatter and structured sections. Use
- **Resources** - Links to errors, tests, PRs, documentation
- **Notes** - Additional context or decisions
**Assessment section fields (for code review findings):**
- Assessment: Clear & Correct | Unclear | Likely Incorrect | YAGNI
- Recommended Action: Fix now | Clarify | Push back | Skip
- Verified: Code, Tests, Usage, Prior Decisions (Yes/No with details)
- Technical Justification: Why this finding is valid or should be skipped
**YAML frontmatter fields:**
```yaml
---

View File

@@ -19,6 +19,22 @@ What is broken, missing, or needs improvement? Provide clear context about why t
- Email service is missing proper error handling for rate-limit scenarios
- Documentation doesn't cover the new authentication flow
## Assessment (Pressure Test)
*(For findings from code review or automated agents)*
| Criterion | Result |
|-----------|--------|
| **Assessment** | Clear & Correct / Unclear / Likely Incorrect / YAGNI |
| **Recommended Action** | Fix now / Clarify / Push back / Skip |
| **Verified Code?** | Yes/No - [what was checked] |
| **Verified Tests?** | Yes/No - [existing coverage] |
| **Verified Usage?** | Yes/No - [how code is used] |
| **Prior Decisions?** | Yes/No - [any intentional design] |
**Technical Justification:**
[If pushing back or marking YAGNI, provide specific technical reasoning. Reference codebase constraints, requirements, or trade-offs.]
## Findings
Investigation results, root cause analysis, and key discoveries.