john/claude-engineering-plugin
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge upstream v2.34.0 with FastAPI pivot (v2.35.0)

Browse Source 
Incorporate 42 upstream commits while preserving the Ruby/Rails → Python/FastAPI
pivot. Each of the 24 conflicting files was individually triaged.

Added: tiangolo-fastapi-reviewer, python-package-readme-writer, lint (Python),
pr-comments-to-todos, fastapi-style skill, python-package-writer skill.

Removed: 3 design agents, ankane-readme-writer, dhh-rails-reviewer,
kieran-rails-reviewer, andrew-kane-gem-writer, dhh-rails-style, dspy-ruby.

Merged: best-practices-researcher, kieran-python-reviewer, resolve_todo_parallel,
file-todos, workflows/review (pressure test), workflows/plan (reviewer names).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
John Lamb
2026-02-16 17:34:54 -06:00
parent 1a3e8e2b58
commit d306c49179
45 changed files with 1533 additions and 8548 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/compound-engineering/agents/research/best-practices-researcher.md
View File

@@ -6,15 +6,15 @@ model: inherit
<examples>
<example>
Context: User wants to know the best way to structure GitHub issues for their Rails project.
Context: User wants to know the best way to structure GitHub issues for their FastAPI project.
user: "I need to create some GitHub issues for our project. Can you research best practices for writing good issues?"
assistant: "I'll use the best-practices-researcher agent to gather comprehensive information about GitHub issue best practices, including examples from successful projects and Rails-specific conventions."
assistant: "I'll use the best-practices-researcher agent to gather comprehensive information about GitHub issue best practices, including examples from successful projects and FastAPI-specific conventions."
<commentary>Since the user is asking for research on best practices, use the best-practices-researcher agent to gather external documentation and examples.</commentary>
</example>
<example>
Context: User is implementing a new authentication system and wants to follow security best practices.
user: "We're adding JWT authentication to our Rails API. What are the current best practices?"
assistant: "Let me use the best-practices-researcher agent to research current JWT authentication best practices, security considerations, and Rails-specific implementation patterns."
user: "We're adding JWT authentication to our FastAPI API. What are the current best practices?"
assistant: "Let me use the best-practices-researcher agent to research current JWT authentication best practices, security considerations, and FastAPI-specific implementation patterns."
<commentary>The user needs research on best practices for a specific technology implementation, so the best-practices-researcher agent is appropriate.</commentary>
</example>
</examples>
@@ -36,7 +36,7 @@ Before going online, check if curated knowledge already exists in skills:
2. **Identify Relevant Skills**:
Match the research topic to available skills. Common mappings:
- Rails/Ruby → `dhh-rails-style`, `andrew-kane-gem-writer`, `dspy-ruby`
- Python/FastAPI → `fastapi-style`, `python-package-writer`
- Frontend/Design → `frontend-design`, `swiss-design`
- TypeScript/React → `react-best-practices`
- AI/Agents → `agent-native-architecture`, `create-agent-skills`
@@ -94,7 +94,7 @@ Only after checking skills AND verifying API availability, gather additional inf
2. **Organize Discoveries**:
- Organize into clear categories (e.g., "Must Have", "Recommended", "Optional")
- Clearly indicate source: "From skill: dhh-rails-style" vs "From official docs" vs "Community consensus"
- Clearly indicate source: "From skill: fastapi-style" vs "From official docs" vs "Community consensus"
- Provide specific examples from real projects when possible
- Explain the reasoning behind each best practice
- Highlight any technology-specific or domain-specific considerations
@@ -117,7 +117,7 @@ For GitHub issue best practices specifically, you will research:
## Source Attribution
Always cite your sources and indicate the authority level:
- **Skill-based**: "The dhh-rails-style skill recommends..." (highest authority - curated)
- **Skill-based**: "The fastapi-style skill recommends..." (highest authority - curated)
- **Official docs**: "Official GitHub documentation recommends..."
- **Community**: "Many successful projects tend to..."