john/claude-engineering-plugin
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #240 from mvanhorn/osc/85-fix-pretooluse-hook-concurrency

Browse Source 
fix(hooks): replace sys.exit(2) with non-fatal tool blocking in PreToolUse
This commit is contained in:
Kieran Klaassen
2026-03-10 16:45:48 -07:00
committed by GitHub
parent 7661a399de 598222e11c
commit c21fbe54e9
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/converter.test.ts
View File

@@ -132,6 +132,18 @@ describe("convertClaudeToOpenCode", () => {
expect(hookFile!.content).toContain("// timeout: 30s")
expect(hookFile!.content).toContain("// Prompt hook for Write|Edit")
expect(hookFile!.content).toContain("// Agent hook for Write|Edit: security-sentinel")
// PreToolUse (tool.execute.before) handlers are wrapped in try-catch
// to prevent hook failures from crashing parallel tool call batches (#85)
const beforeIdx = hookFile!.content.indexOf('"tool.execute.before"')
const afterIdx = hookFile!.content.indexOf('"tool.execute.after"')
const beforeBlock = hookFile!.content.slice(beforeIdx, afterIdx)
expect(beforeBlock).toContain("try {")
expect(beforeBlock).toContain("} catch (err) {")
// PostToolUse (tool.execute.after) handlers are NOT wrapped in try-catch
const afterBlock = hookFile!.content.slice(afterIdx, hookFile!.content.indexOf('"session.created"'))
expect(afterBlock).not.toContain("try {")
})
test("converts MCP servers", async () => {