diff --git a/plugins/compound-engineering/commands/workflows/review.md b/plugins/compound-engineering/commands/workflows/review.md index d0ba78f..570cf49 100644 --- a/plugins/compound-engineering/commands/workflows/review.md +++ b/plugins/compound-engineering/commands/workflows/review.md @@ -38,7 +38,7 @@ First, I need to determine the review target type and set up the code for analys - [ ] Determine review type: PR number (numeric), GitHub URL, file path (.md), or empty (current branch) - [ ] Check current git branch - [ ] If ALREADY on the target branch (PR branch, requested branch name, or the branch already checked out for review) → proceed with analysis on current branch -- [ ] If DIFFERENT branch than the review target → offer to use worktree: "Use git-worktree skill for isolated Call `skill: git-worktree` with branch name +- [ ] If DIFFERENT branch than the review target → offer to use worktree: "Use git-worktree skill for isolated Call `skill: git-worktree` with branch name" - [ ] Fetch PR metadata using `gh pr view --json` for title, body, files, linked issues - [ ] Set up language-specific analysis tools - [ ] Prepare security scanning environment @@ -106,7 +106,7 @@ These agents are run ONLY when the PR matches specific criteria. Check the PR fi -### 4. Ultra-Thinking Deep Dive Phases +### 2. Ultra-Thinking Deep Dive Phases For each phase below, spend maximum cognitive effort. Think step by step. Consider all angles. Question assumptions. And bring all reviews in a synthesis to the user. @@ -114,7 +114,7 @@ These agents are run ONLY when the PR matches specific criteria. Check the PR fi Complete system context map with component interactions -#### Phase 3: Stakeholder Perspective Analysis +#### Phase 1: Stakeholder Perspective Analysis ULTRA-THINK: Put yourself in each stakeholder's shoes. What matters to them? What are their pain points? @@ -154,7 +154,7 @@ Complete system context map with component interactions - How does this affect time-to-market? - What's the total cost of ownership? -#### Phase 4: Scenario Exploration +#### Phase 2: Scenario Exploration ULTRA-THINK: Explore edge cases and failure scenarios. What could go wrong? How does the system behave under stress? @@ -171,7 +171,7 @@ Complete system context map with component interactions - [ ] **Data Corruption**: Partial writes, inconsistency - [ ] **Cascading Failures**: Downstream service issues -### 6. Multi-Angle Review Perspectives +### 3. Multi-Angle Review Perspectives #### Technical Excellence Angle @@ -401,7 +401,6 @@ After creating all todo files, present comprehensive summary: ls todos/*-pending-*.md # View all pending todos /triage # Use slash command for interactive triage ``` -```` 3. **Work on Approved Todos**: @@ -436,10 +435,9 @@ After creating all todo files, present comprehensive summary: - Code cleanup - Optimization opportunities - Documentation updates +```` -``` - -### 7. End-to-End Testing (Optional) +### 6. End-to-End Testing (Optional) @@ -525,4 +523,3 @@ The subagent will: ### Important: P1 Findings Block Merge Any **🔴 P1 (CRITICAL)** findings must be addressed before merging the PR. Present these prominently and ensure they're resolved before accepting the PR. -```