From aabad4a75a7fb6433521f9e68e5822d091520ed9 Mon Sep 17 00:00:00 2001 From: John Lamb Date: Fri, 24 Apr 2026 14:04:22 -0500 Subject: [PATCH] =?UTF-8?q?Merge=20step=20(i):=20reference=20sweep=20?= =?UTF-8?q?=E2=80=94=20fix=20stray=20old-convention=20refs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Applies triage doc 022. Most of the sweep was no-op because upstream already renamed everything in place when we branched from origin/main. Remaining fixes: - ce-pr-comments-review/SKILL.md: replace compound-engineering:review:/ workflow: prefixed agent refs with bare ce- form (self-correction from step g where I accidentally used old convention) - ce-essay-edit/SKILL.md: update /essay-outline reference to /ce-essay-outline Prose references to generic words ("onboarding", "changelog") are left alone — they are natural-language uses, not skill references. Known follow-up: tests/review-skill-contract.test.ts and tests/legacy-cleanup.test.ts still reference locally-removed agents (ce-dhh-rails-reviewer, ce-kieran-rails-reviewer, ce-data-migration-expert, ce-security-sentinel). These will need test updates + registration of removed names in src/utils/legacy-cleanup.ts and src/data/plugin-legacy-artifacts.ts — flagged for step (j). Co-Authored-By: Claude Opus 4.7 (1M context) --- plugins/compound-engineering/skills/ce-essay-edit/SKILL.md | 2 +- .../skills/ce-pr-comments-review/SKILL.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/compound-engineering/skills/ce-essay-edit/SKILL.md b/plugins/compound-engineering/skills/ce-essay-edit/SKILL.md index a4fb6e7..b2f09bc 100644 --- a/plugins/compound-engineering/skills/ce-essay-edit/SKILL.md +++ b/plugins/compound-engineering/skills/ce-essay-edit/SKILL.md @@ -1,6 +1,6 @@ --- name: ce-essay-edit -description: Expert essay editor that polishes written work through granular line-level editing and structural review. Preserves the author's voice and intent — never softens or genericizes. Pairs with /essay-outline. +description: Expert essay editor that polishes written work through granular line-level editing and structural review. Preserves the author's voice and intent — never softens or genericizes. Pairs with /ce-essay-outline. argument-hint: "[path to essay file, or paste the essay]" --- diff --git a/plugins/compound-engineering/skills/ce-pr-comments-review/SKILL.md b/plugins/compound-engineering/skills/ce-pr-comments-review/SKILL.md index 80af1f7..661b721 100644 --- a/plugins/compound-engineering/skills/ce-pr-comments-review/SKILL.md +++ b/plugins/compound-engineering/skills/ce-pr-comments-review/SKILL.md @@ -53,7 +53,7 @@ Group comments by file + line + thread for context. Skip: For each remaining comment, dispatch a validator agent. In Claude Code: ``` -Agent(subagent_type: "compound-engineering:review:ce-zip-agent-validator", +Agent(subagent_type: "ce-zip-agent-validator", description: "Validate PR comment", prompt: "") ``` @@ -109,7 +109,7 @@ Order findings: `Clear & Correct` and `Likely Incorrect` first (they drive the b Apply decisions in parallel where possible. -- **Fix now** → dispatch `compound-engineering:workflow:ce-pr-comment-resolver` per finding (or grouped set). Prefer parallel; fall back to sequential if dependencies exist. When the resolver is done, post a reply on the thread confirming the fix and include the commit SHA. +- **Fix now** → dispatch `ce-pr-comment-resolver` per finding (or grouped set). Prefer parallel; fall back to sequential if dependencies exist. When the resolver is done, post a reply on the thread confirming the fix and include the commit SHA. - **Clarify** → post the clarifying reply on the thread via `gh api`. Do not mark the thread resolved. - **Push back** → post the disagreement (pulling the technical justification from the validator result) on the thread. Do not mark the thread resolved. - **Skip** → do nothing on the thread. Note the skip reason in the task summary.