From a83e11e982e1b5b0b264b6ab63bc74e3a50f7c28 Mon Sep 17 00:00:00 2001 From: Trevin Chow Date: Tue, 17 Mar 2026 10:39:02 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20review=20fixes=20=E2=80=94=20stale=20ref?= =?UTF-8?q?s,=20skill=20counts,=20and=20validation=20guidance?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix -plan.md → -beta-plan.md in ce:plan-beta post-generation question - Remove stale brainstorm doc reference from solutions doc - Update plugin.json and marketplace.json skill counts (42 → 44) - Add generic beta skill validation guidance to AGENTS.md and solutions doc --- .claude-plugin/marketplace.json | 2 +- docs/solutions/skill-design/beta-skills-framework.md | 11 ++++++++++- .../compound-engineering/.claude-plugin/plugin.json | 2 +- plugins/compound-engineering/AGENTS.md | 8 ++++++++ .../compound-engineering/skills/ce-plan-beta/SKILL.md | 2 +- 5 files changed, 21 insertions(+), 4 deletions(-) diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index b64732d..9299a25 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -11,7 +11,7 @@ "plugins": [ { "name": "compound-engineering", - "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 29 specialized agents and 42 skills.", + "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 29 specialized agents and 44 skills.", "version": "2.41.0", "author": { "name": "Kieran Klaassen", diff --git a/docs/solutions/skill-design/beta-skills-framework.md b/docs/solutions/skill-design/beta-skills-framework.md index 7780cef..d0751fa 100644 --- a/docs/solutions/skill-design/beta-skills-framework.md +++ b/docs/solutions/skill-design/beta-skills-framework.md @@ -12,7 +12,6 @@ tags: severity: medium description: "Pattern for trialing new skill versions alongside stable ones using a -beta suffix. Covers naming, plan file naming, internal references, and promotion path." related: - - docs/brainstorms/2026-03-17-beta-skills-framework-brainstorm.md - docs/solutions/skill-design/compound-refresh-skill-improvements.md --- @@ -80,8 +79,18 @@ When the beta version is validated: 8. Verify `lfg`/`slfg` work with the promoted skill 9. Verify `ce:work` consumes plans from the promoted skill +## Validation + +After creating a beta skill, search its SKILL.md for references to the stable skill name it replaces. Any occurrence of the stable name without `-beta` is a missed rename — it would cause output collisions or route to the wrong skill. + +Check for: +- **Output file paths** that use the stable naming convention instead of the `-beta` variant +- **Cross-skill references** that point to stable skill names instead of beta counterparts +- **User-facing text** (questions, confirmations) that mentions stable paths or names + ## Prevention - When adding a beta skill, always use the `-beta` suffix consistently in directory name, frontmatter name, description, plan file naming, and all internal skill-to-skill references +- After creating a beta skill, run the validation checks above to catch missed renames in file paths, user-facing text, and cross-skill references - Always test that stable skills are completely unaffected by the beta skill's existence - Keep beta and stable plan file suffixes distinct so outputs can coexist for comparison diff --git a/plugins/compound-engineering/.claude-plugin/plugin.json b/plugins/compound-engineering/.claude-plugin/plugin.json index 115f818..4e7dd86 100644 --- a/plugins/compound-engineering/.claude-plugin/plugin.json +++ b/plugins/compound-engineering/.claude-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "compound-engineering", "version": "2.41.0", - "description": "AI-powered development tools. 29 agents, 42 skills, 1 MCP server for code review, research, design, and workflow automation.", + "description": "AI-powered development tools. 29 agents, 44 skills, 1 MCP server for code review, research, design, and workflow automation.", "author": { "name": "Kieran Klaassen", "email": "kieran@every.to", diff --git a/plugins/compound-engineering/AGENTS.md b/plugins/compound-engineering/AGENTS.md index 715bd18..21e4679 100644 --- a/plugins/compound-engineering/AGENTS.md +++ b/plugins/compound-engineering/AGENTS.md @@ -131,6 +131,14 @@ See `docs/solutions/skill-design/beta-skills-framework.md` for the full pattern. - Beta plan output files use `-beta-plan.md` suffix to avoid clobbering stable plan files - Beta skills are not wired into `lfg`/`slfg` orchestration — invoke them directly +### Beta Skill Validation + +After creating or modifying a beta skill, search its SKILL.md for any reference to the stable skill name it replaces. Occurrences of the stable name without `-beta` are missed renames that would cause output collisions or misrouting. Check for: + +- Output file paths using the stable naming convention instead of the `-beta` variant +- Cross-skill references pointing to stable names instead of beta counterparts +- User-facing text (questions, confirmations) mentioning stable paths or names + ### Promoting Beta to Stable When replacing a stable skill with its beta version: diff --git a/plugins/compound-engineering/skills/ce-plan-beta/SKILL.md b/plugins/compound-engineering/skills/ce-plan-beta/SKILL.md index f3230ef..c9be382 100644 --- a/plugins/compound-engineering/skills/ce-plan-beta/SKILL.md +++ b/plugins/compound-engineering/skills/ce-plan-beta/SKILL.md @@ -511,7 +511,7 @@ Plan written to docs/plans/[filename] After writing the plan file, present the options using the platform's blocking question tool when available (see Interaction Method). Otherwise present numbered options in chat and wait for the user's reply before proceeding. -**Question:** "Plan ready at `docs/plans/YYYY-MM-DD-NNN---plan.md`. What would you like to do next?" +**Question:** "Plan ready at `docs/plans/YYYY-MM-DD-NNN---beta-plan.md`. What would you like to do next?" **Options:** 1. **Open plan in editor** - Open the plan file for review