feat(plugin): reorganize compounding-engineering v2.0.0

Major restructure of the compounding-engineering plugin: ## Agents (24 total, now categorized) - review/ (10): architecture-strategist, code-simplicity-reviewer, data-integrity-guardian, dhh-rails-reviewer, kieran-rails-reviewer, kieran-python-reviewer, kieran-typescript-reviewer, pattern-recognition-specialist, performance-oracle, security-sentinel - research/ (4): best-practices-researcher, framework-docs-researcher, git-history-analyzer, repo-research-analyst - design/ (3): design-implementation-reviewer, design-iterator, figma-design-sync - workflow/ (6): bug-reproduction-validator, every-style-editor, feedback-codifier, lint, pr-comment-resolver, spec-flow-analyzer - docs/ (1): ankane-readme-writer ## Commands (15 total) - Moved workflow commands to commands/workflows/ subdirectory - Added: changelog, create-agent-skill, heal-skill, plan_review, prime, reproduce-bug, resolve_parallel, resolve_pr_parallel ## Skills (11 total) - Added: andrew-kane-gem-writer, codify-docs, create-agent-skills, dhh-ruby-style, dspy-ruby, every-style-editor, file-todos, frontend-design, git-worktree, skill-creator - Kept: gemini-imagegen 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-24 11:42:18 -08:00
parent 8cd694c518
commit 8cc99ab483
99 changed files with 16491 additions and 647 deletions
--- a/plugins/compounding-engineering/commands/triage.md
+++ b/plugins/compounding-engineering/commands/triage.md
@@ -1,8 +1,18 @@
+---
+name: triage
+description: Triage and categorize findings for the CLI todo system
+argument-hint: "[findings list or source type]"
+---
+
+- First set the /model to Haiku
+- Then read all pending todos in the todos/ directory
+
 Present all findings, decisions, or issues here one by one for triage. The goal is to go through each item and decide whether to add it to the CLI todo system.

 **IMPORTANT: DO NOT CODE ANYTHING DURING TRIAGE!**

 This command is for:
+
 - Triaging code review findings
 - Processing security audit results
 - Reviewing performance analysis
@@ -46,38 +56,43 @@ Do you want to add this to the todo list?

 **When user says "yes":**

-1. **Determine next issue ID:**
-   ```bash
-   ls todos/ | grep -o '^[0-9]\+' | sort -n | tail -1
-   ```
+1. **Update existing todo file** (if it exists) or **Create new filename:**
+
+   If todo already exists (from code review):
+
+   - Rename file from `{id}-pending-{priority}-{desc}.md` → `{id}-ready-{priority}-{desc}.md`
+   - Update YAML frontmatter: `status: pending` → `status: ready`
+   - Keep issue_id, priority, and description unchanged
+
+   If creating new todo:

-2. **Create filename:**
   ```
-   {next_id}-pending-{priority}-{brief-description}.md
+   {next_id}-ready-{priority}-{brief-description}.md
   ```

   Priority mapping:
+
   - 🔴 P1 (CRITICAL) → `p1`
   - 🟡 P2 (IMPORTANT) → `p2`
   - 🔵 P3 (NICE-TO-HAVE) → `p3`

-   Example: `042-pending-p1-transaction-boundaries.md`
+   Example: `042-ready-p1-transaction-boundaries.md`

-3. **Create from template:**
-   ```bash
-   cp todos/000-pending-p1-TEMPLATE.md todos/{new_filename}
-   ```
+2. **Update YAML frontmatter:**

-4. **Populate the file:**
   ```yaml
   ---
-   status: pending
-   priority: p1  # or p2, p3 based on severity
+   status: ready # IMPORTANT: Change from "pending" to "ready"
+   priority: p1 # or p2, p3 based on severity
   issue_id: "042"
   tags: [category, relevant-tags]
   dependencies: []
   ---
+   ```

+3. **Populate or update the file:**
+
+   ```yaml
   # [Issue Title]

   ## Problem Statement
@@ -97,7 +112,7 @@ Do you want to add this to the todo list?
   - **Risk**: [Low/Medium/High]

   ## Recommended Action
-   [Leave blank - will be filled during approval]
+   [Filled during triage - specific action plan]

   ## Technical Details
   - **Affected Files**: [List files]
@@ -115,12 +130,12 @@ Do you want to add this to the todo list?

   ## Work Log

-   ### {date} - Initial Discovery
+   ### {date} - Approved for Work
   **By:** Claude Triage System
   **Actions:**
-   - Issue discovered during [triage session type]
-   - Categorized as {severity}
-   - Estimated effort: {effort}
+   - Issue approved during triage session
+   - Status changed from pending → ready
+   - Ready to be picked up and worked on

   **Learnings:**
   - [Context and insights]
@@ -129,14 +144,16 @@ Do you want to add this to the todo list?
   Source: Triage session on {date}
   ```

-5. **Confirm creation:**
-   "✅ Created: `{filename}` - Issue #{issue_id}"
+4. **Confirm approval:** "✅ Approved: `{new_filename}` (Issue #{issue_id}) - Status: **ready** → Ready to work on"

 **When user says "next":**
+
+- **Delete the todo file** - Remove it from todos/ directory since it's not relevant
 - Skip to the next item
 - Track skipped items for summary

 **When user says "custom":**
+
 - Ask what to modify (priority, description, details)
 - Update the information
 - Present revised version
@@ -152,52 +169,76 @@ Do you want to add this to the todo list?

 After all items processed:

-```markdown
+````markdown
 ## Triage Complete

-**Total Items:** [X]
-**Todos Created:** [Y]
-**Skipped:** [Z]
+**Total Items:** [X] **Todos Approved (ready):** [Y] **Skipped:** [Z]

-### Created Todos:
- `042-pending-p1-transaction-boundaries.md` - Transaction boundary issue
- `043-pending-p2-cache-optimization.md` - Cache performance improvement
-...
+### Approved Todos (Ready for Work):

-### Skipped Items:
- Item #5: [reason]
- Item #12: [reason]
+- `042-ready-p1-transaction-boundaries.md` - Transaction boundary issue
+- `043-ready-p2-cache-optimization.md` - Cache performance improvement ...
+
+### Skipped Items (Deleted):
+
+- Item #5: [reason] - Removed from todos/
+- Item #12: [reason] - Removed from todos/
+
+### Summary of Changes Made:
+
+During triage, the following status updates occurred:
+
+- **Pending → Ready:** Filenames and frontmatter updated to reflect approved status
+- **Deleted:** Todo files for skipped findings removed from todos/ directory
+- Each approved file now has `status: ready` in YAML frontmatter

 ### Next Steps:
-1. Review pending todos: `ls todos/*-pending-*.md`
-2. Approve for work: Move from pending → ready status
-3. Start work: Use `/resolve_todo_parallel` or pick individually
+
+1. View approved todos ready for work:
+   ```bash
+   ls todos/*-ready-*.md
+   ```
+````
+
+2. Start work on approved items:
+
+   ```bash
+   /resolve_todo_parallel  # Work on multiple approved items efficiently
+   ```
+
+3. Or pick individual items to work on
+
+4. As you work, update todo status:
+   - Ready → In Progress (in your local context as you work)
+   - In Progress → Complete (rename file: ready → complete, update frontmatter)
+
 ```

 ## Example Response Format

 ```
+
 ---
+
 Issue #5: Missing Transaction Boundaries for Multi-Step Operations

 Severity: 🔴 P1 (CRITICAL)

 Category: Data Integrity / Security

-Description:
-The google_oauth2_connected callback in GoogleOauthCallbacks concern performs multiple database
-operations without transaction protection. If any step fails midway, the database is left in an
-inconsistent state.
+Description: The google_oauth2_connected callback in GoogleOauthCallbacks concern performs multiple database operations without transaction protection. If any step fails midway, the database is left in an inconsistent state.

 Location: app/controllers/concerns/google_oauth_callbacks.rb:13-50

 Problem Scenario:
+
 1. User.update succeeds (email changed)
 2. Account.save! fails (validation error)
 3. Result: User has changed email but no associated Account
 4. Next login attempt fails completely

 Operations Without Transaction:
+
 - User confirmation (line 13)
 - Waitlist removal (line 14)
 - User profile update (line 21-23)
@@ -205,18 +246,65 @@ Operations Without Transaction:
 - Avatar attachment (line 39-45)
 - Journey creation (line 47)

-Proposed Solution:
-Wrap all operations in ApplicationRecord.transaction do ... end block
+Proposed Solution: Wrap all operations in ApplicationRecord.transaction do ... end block

 Estimated Effort: Small (30 minutes)

 ---
+
 Do you want to add this to the todo list?
+
 1. yes - create todo file
 2. next - skip this item
 3. custom - modify before creating
+
 ```

-Do not code, and if you say yes, make sure to mark the to‑do as ready to pick up or something. If you make any changes, update the file and then continue to read the next one. If next is selecrte make sure to remove the to‑do from the list since its not relevant.
+## Important Implementation Details

-Every time you present the to‑do as a header, can you say what the progress of the triage is, how many we have done and how many are left, and an estimated time for completion, looking at how quickly we go through them as well?
+### Status Transitions During Triage
+
+**When "yes" is selected:**
+1. Rename file: `{id}-pending-{priority}-{desc}.md` → `{id}-ready-{priority}-{desc}.md`
+2. Update YAML frontmatter: `status: pending` → `status: ready`
+3. Update Work Log with triage approval entry
+4. Confirm: "✅ Approved: `{filename}` (Issue #{issue_id}) - Status: **ready**"
+
+**When "next" is selected:**
+1. Delete the todo file from todos/ directory
+2. Skip to next item
+3. No file remains in the system
+
+### Progress Tracking
+
+Every time you present a todo as a header, include:
+- **Progress:** X/Y completed (e.g., "3/10 completed")
+- **Estimated time remaining:** Based on how quickly you're progressing
+- **Pacing:** Monitor time per finding and adjust estimate accordingly
+
+Example:
+```
+
+Progress: 3/10 completed | Estimated time: ~2 minutes remaining
+
+```
+
+### Do Not Code During Triage
+
+- ✅ Present findings
+- ✅ Make yes/next/custom decisions
+- ✅ Update todo files (rename, frontmatter, work log)
+- ❌ Do NOT implement fixes or write code
+- ❌ Do NOT add detailed implementation details
+- ❌ That's for /resolve_todo_parallel phase
+```
+
+When done give these options
+
+```markdown
+What would you like to do next?
+
+1. run /resolve_todo_parallel to resolve the todos
+2. commit the todos
+3. nothing, go chill
+```