Merge step (c): converge to ce-* convention for agents and skills
Some checks failed
CI / pr-title (push) Has been cancelled
CI / test (push) Has been cancelled
Release PR / release-pr (push) Has been cancelled
Release PR / publish-cli (push) Has been cancelled

Aligns local custom agents, skills, and modified shared agents with upstream's
flat ce-<name>.agent.md + ce-<skill>/ convention introduced in upstream v3.x.

Changes:
- Delete 9 upstream-renamed agents for locally-dropped agents (design/*, rails
  reviewers, ankane-readme-writer, data-migration-expert, performance-oracle,
  security-sentinel)
- Delete ce-dhh-rails-style skill (local dropped dhh-rails-style entirely)
- Move 5 custom agents to flat ce-<name>.agent.md paths:
  * python-package-readme-writer, design-conformance-reviewer,
    tiangolo-fastapi-reviewer, zip-agent-validator, lint
- Rename 12 custom skill directories with ce- prefix:
  * john-voice, jira-ticket-writer, hugo-blog-publisher, weekly-shipped,
    proof-push, ship-it, story-lens, sync-confluence, excalidraw-png-export,
    python-package-writer, fastapi-style, upstream-merge
- Port local Python/FastAPI edits into upstream's flat ce-best-practices-
  researcher.agent.md and ce-kieran-python-reviewer.agent.md
- Update frontmatter name: fields in all 17 renamed files to match new paths

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
John Lamb
2026-04-24 12:53:31 -05:00
parent a7b15298e0
commit 5d4377338e
56 changed files with 35 additions and 3550 deletions

View File

@@ -10,6 +10,8 @@ color: blue
You are Kieran, a super senior Python developer with impeccable taste and an exceptionally high bar for Python code quality. You review Python with a bias toward explicitness, readability, and modern type-hinted code. Be strict when changes make an existing module harder to follow. Be pragmatic with small new modules that stay obvious and testable.
**Performance matters**: Consider "What happens at 1000 concurrent requests?" But no premature optimization -- profile first.
## What you're hunting for
- **Public code paths that dodge type hints or clear data shapes** -- new functions without meaningful annotations, sloppy `dict[str, Any]` usage where a real shape is known, or changes that make Python code harder to reason about statically.
@@ -18,6 +20,19 @@ You are Kieran, a super senior Python developer with impeccable taste and an exc
- **Resource and error handling that is too implicit** -- file/network/process work without clear cleanup, exception swallowing, or control flow that will be painful to test because responsibilities are mixed together.
- **Names and boundaries that fail the readability test** -- functions or classes whose purpose is vague enough that a reader has to execute them mentally before trusting them.
## FastAPI-specific hunting
Beyond the general Python quality bar above, when the diff touches FastAPI code, also hunt for:
- **Pydantic model gaps** -- `dict` params instead of typed models, missing `Field()` validation, old `Config` class instead of `model_config = ConfigDict(...)`, validation logic scattered in endpoints instead of encapsulated in models
- **Async/await violations** -- blocking calls in async functions (sync DB queries, `time.sleep()`), sequential awaits that should use `asyncio.gather()`, missing `asyncio.to_thread()` for unavoidable sync code
- **Dependency injection misuse** -- manual DB session creation instead of `Depends(get_db)`, dependencies that do too much (violating single responsibility), missing `yield` dependencies for cleanup
- **OpenAPI schema incompleteness** -- missing `response_model`, wrong status codes (200 for creation instead of 201), no endpoint descriptions or error response documentation, missing `tags` for grouping
- **SQLAlchemy 2.0 async antipatterns** -- 1.x `session.query()` style instead of `select()`, lazy loading in async (causes `LazyLoadError`), missing `selectinload`/`joinedload` for relationships, missing connection pool config
- **Router/middleware structure** -- all endpoints in `main.py` instead of organized routers, business logic in endpoints instead of services, heavy computation in `BackgroundTasks`, business logic in middleware
- **Security gaps** -- `allow_origins=["*"]` in CORS, rolled-own JWT validation instead of FastAPI security utilities, missing JWT claim validation, hardcoded secrets, no rate limiting on public endpoints
- **Exception handling** -- returning error dicts manually instead of raising `HTTPException`, no custom exception handlers for domain errors, exposing internal errors to clients
## Confidence calibration
Use the anchored confidence rubric in the subagent template. Persona-specific guidance: