john/claude-engineering-plugin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(cli)!: rename all skills and agents to consistent ce- prefix (#503)
Some checks failed
CI / pr-title (push) Has been cancelled
Details
CI / test (push) Has been cancelled
Details
Release PR / release-pr (push) Has been cancelled
Details
Release PR / publish-cli (push) Has been cancelled
Details

Browse Source 
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trevin Chow
2026-04-18 15:44:22 -07:00
committed by GitHub
parent 49249d7317
commit 5c0ec9137a
233 changed files with 3199 additions and 936 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
tests/pipeline-review-contract.test.ts
View File

@@ -6,7 +6,7 @@ async function readRepoFile(relativePath: string): Promise<string> {
return readFile(path.join(process.cwd(), relativePath), "utf8")
}
describe("ce:work review contract", () => {
describe("ce-work review contract", () => {
test("requires code review before shipping", async () => {
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work/SKILL.md")
// Review content extracted to references/shipping-workflow.md
@@ -23,11 +23,11 @@ describe("ce:work review contract", () => {
// Two-tier rubric in reference file
expect(shipping).toContain("**Tier 1: Inline self-review**")
expect(shipping).toContain("**Tier 2: Full review (default)**")
expect(shipping).toContain("ce:review")
expect(shipping).toContain("ce-code-review")
expect(shipping).toContain("mode:autofix")
// Quality checklist includes review
expect(shipping).toContain("Code review completed (inline self-review or full `ce:review`)")
expect(shipping).toContain("Code review completed (inline self-review or full `ce-code-review`)")
})
test("delegates commit and PR to dedicated skills", async () => {
@@ -35,23 +35,23 @@ describe("ce:work review contract", () => {
// Commit/PR delegation content extracted to references/shipping-workflow.md
const shipping = await readRepoFile("plugins/compound-engineering/skills/ce-work/references/shipping-workflow.md")
expect(shipping).toContain("`git-commit-push-pr` skill")
expect(shipping).toContain("`git-commit` skill")
expect(shipping).toContain("`ce-commit-push-pr` skill")
expect(shipping).toContain("`ce-commit` skill")
// Should not contain inline PR templates or attribution placeholders
expect(content).not.toContain("gh pr create")
expect(content).not.toContain("[HARNESS_URL]")
})
test("ce:work-beta mirrors review and commit delegation", async () => {
test("ce-work-beta mirrors review and commit delegation", async () => {
const beta = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
// Review/commit content extracted to references/shipping-workflow.md
const shipping = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/references/shipping-workflow.md")
// Extracted content in reference file
expect(shipping).toContain("2. **Code Review**")
expect(shipping).toContain("`git-commit-push-pr` skill")
expect(shipping).toContain("`git-commit` skill")
expect(shipping).toContain("`ce-commit-push-pr` skill")
expect(shipping).toContain("`ce-commit` skill")
// Negative assertions stay on SKILL.md
expect(beta).not.toContain("Consider Code Review")
@@ -86,7 +86,7 @@ describe("ce:work review contract", () => {
expect(shipping).not.toContain("Tests pass (run project's test command)")
})
test("ce:work-beta mirrors testing deliberation and checklist changes", async () => {
test("ce-work-beta mirrors testing deliberation and checklist changes", async () => {
const beta = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
// Checklist extracted to references/shipping-workflow.md
const shipping = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/references/shipping-workflow.md")
@@ -162,8 +162,8 @@ describe("ce:work-beta codex delegation contract", () => {
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
expect(content).toContain("disable-model-invocation: true")
expect(content).toContain("Invoke `ce:work-beta` manually")
expect(content).toContain("planning and workflow handoffs remain pointed at stable `ce:work`")
expect(content).toContain("Invoke `ce-work-beta` manually")
expect(content).toContain("planning and workflow handoffs remain pointed at stable `ce-work`")
})
test("SKILL.md has delegation routing stub pointing to reference", async () => {
@@ -253,7 +253,7 @@ describe("ce:work-beta codex delegation contract", () => {
const content = await readRepoFile("plugins/compound-engineering/skills/ce-work-beta/SKILL.md")
expect(content).toContain("**Frontend Design Guidance**")
expect(content).toContain("`frontend-design` skill")
expect(content).toContain("`ce-frontend-design` skill")
})
})
@@ -272,28 +272,28 @@ describe("ce:plan remains neutral during ce:work-beta rollout", () => {
})
})
describe("ce:brainstorm review contract", () => {
describe("ce-brainstorm review contract", () => {
test("requires document review before handoff", async () => {
const content = await readRepoFile("plugins/compound-engineering/skills/ce-brainstorm/SKILL.md")
// Phase 3.5 exists and runs document-review
expect(content).toContain("### Phase 3.5: Document Review")
expect(content).toContain("`document-review` skill")
expect(content).toContain("`ce-doc-review` skill")
// Phase 3 and Phase 4 are extracted to references for token optimization
expect(content).toContain("`references/requirements-capture.md`")
expect(content).toContain("`references/handoff.md`")
// Additional review passes are surfaced contextually (not as a menu fixture) and still
// route through the document-review skill when requested
// route through the ce-doc-review skill when requested
const handoff = await readRepoFile("plugins/compound-engineering/skills/ce-brainstorm/references/handoff.md")
expect(handoff).toContain("Surface additional document review contextually")
expect(handoff).toContain("Load the `document-review` skill")
expect(handoff).toContain("Load the `ce-doc-review` skill")
expect(handoff).not.toContain("**Review and refine**")
})
})
describe("ce:plan testing contract", () => {
describe("ce-plan testing contract", () => {
test("flags blank test scenarios on feature-bearing units as incomplete", async () => {
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/SKILL.md")
@@ -306,14 +306,14 @@ describe("ce:plan testing contract", () => {
})
})
describe("ce:plan review contract", () => {
describe("ce-plan review contract", () => {
test("requires document review after confidence check", async () => {
// Document review instructions extracted to references/plan-handoff.md
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/references/plan-handoff.md")
// Phase 5.3.8 runs document-review before final checks (5.3.9)
expect(content).toContain("## 5.3.8 Document Review")
expect(content).toContain("`document-review` skill")
expect(content).toContain("`ce-doc-review` skill")
// Document review must come before final checks so auto-applied edits are validated
const docReviewIdx = content.indexOf("5.3.8 Document Review")
@@ -333,23 +333,23 @@ describe("ce:plan review contract", () => {
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/references/plan-handoff.md")
// Pipeline mode runs document-review headlessly, not skipping it
expect(content).toContain("document-review` with `mode:headless`")
expect(content).toContain("ce-doc-review` with `mode:headless`")
expect(content).not.toContain("skip document-review and return control")
})
test("handoff options recommend ce:work after review", async () => {
test("handoff options recommend ce-work after review", async () => {
const content = await readRepoFile("plugins/compound-engineering/skills/ce-plan/references/plan-handoff.md")
// ce:work is recommended (review already happened)
expect(content).toContain("**Start `/ce:work`** (recommended) - Begin implementing this plan in the current session")
// ce-work is recommended (review already happened)
expect(content).toContain("**Start `/ce-work`** (recommended) - Begin implementing this plan in the current session")
// Additional review passes are surfaced contextually (not as a menu fixture) and still
// route through the document-review skill when requested
// route through the ce-doc-review skill when requested
expect(content).toContain("Surface additional document review contextually")
expect(content).toContain("Load the `document-review` skill")
expect(content).toContain("Load the `ce-doc-review` skill")
// No conditional ordering based on plan depth (review already ran)
expect(content).not.toContain("**Options when document-review is recommended:**")
expect(content).not.toContain("**Options when ce-doc-review is recommended:**")
expect(content).not.toContain("**Options for Standard or Lightweight plans:**")
})
})