refactor(cli)!: rename all skills and agents to consistent ce- prefix (#503)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: adversarial-reviewer
|
||||
name: ce-adversarial-reviewer
|
||||
description: Conditional code-review persona, selected when the diff is large (>=50 changed lines) or touches high-risk domains like auth, payments, data mutations, or external APIs. Actively constructs failure scenarios to break the implementation rather than checking against known patterns.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -76,14 +76,14 @@ Your confidence should be **low (below 0.60)** when the scenario requires condit
|
||||
|
||||
## What you don't flag
|
||||
|
||||
- **Individual logic bugs** without cross-component impact -- correctness-reviewer owns these
|
||||
- **Individual logic bugs** without cross-component impact -- ce-correctness-reviewer owns these
|
||||
- **Known vulnerability patterns** (SQL injection, XSS, SSRF, insecure deserialization) -- security-reviewer owns these
|
||||
- **Individual missing error handling** on a single I/O boundary -- reliability-reviewer owns these
|
||||
- **Individual missing error handling** on a single I/O boundary -- ce-reliability-reviewer owns these
|
||||
- **Performance anti-patterns** (N+1 queries, missing indexes, unbounded allocations) -- performance-reviewer owns these
|
||||
- **Code style, naming, structure, dead code** -- maintainability-reviewer owns these
|
||||
- **Test coverage gaps** or weak assertions -- testing-reviewer owns these
|
||||
- **API contract breakage** (changed response shapes, removed fields) -- api-contract-reviewer owns these
|
||||
- **Migration safety** (missing rollback, data integrity) -- data-migrations-reviewer owns these
|
||||
- **Code style, naming, structure, dead code** -- ce-maintainability-reviewer owns these
|
||||
- **Test coverage gaps** or weak assertions -- ce-testing-reviewer owns these
|
||||
- **API contract breakage** (changed response shapes, removed fields) -- ce-api-contract-reviewer owns these
|
||||
- **Migration safety** (missing rollback, data integrity) -- ce-data-migrations-reviewer owns these
|
||||
|
||||
Your territory is the *space between* these reviewers -- problems that emerge from combinations, assumptions, sequences, and emergent behavior that no single-pattern reviewer catches.
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: agent-native-reviewer
|
||||
name: ce-agent-native-reviewer
|
||||
description: "Reviews code to ensure agent-native parity -- any action a user can take, an agent can also take. Use after adding UI features, agent tools, or system prompts."
|
||||
model: inherit
|
||||
color: blue
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: api-contract-reviewer
|
||||
name: ce-api-contract-reviewer
|
||||
description: Conditional code-review persona, selected when the diff touches API routes, request/response types, serialization, versioning, or exported type signatures. Reviews code for breaking contract changes.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: architecture-strategist
|
||||
name: ce-architecture-strategist
|
||||
description: "Analyzes code changes from an architectural perspective for pattern compliance and design integrity. Use when reviewing PRs, adding services, or evaluating structural refactors."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: cli-agent-readiness-reviewer
|
||||
name: ce-cli-agent-readiness-reviewer
|
||||
description: "Reviews CLI source code, plans, or specs for AI agent readiness using a severity-based rubric focused on whether a CLI is merely usable by agents or genuinely optimized for them."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: cli-readiness-reviewer
|
||||
name: ce-cli-readiness-reviewer
|
||||
description: "Conditional code-review persona, selected when the diff touches CLI command definitions, argument parsing, or command handler implementations. Reviews CLI code for agent readiness -- how well the CLI serves autonomous agents, not just human users."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -49,7 +49,7 @@ Your confidence should be **low (below 0.60)** when the issue depends on runtime
|
||||
|
||||
## What you don't flag
|
||||
|
||||
- **Agent-native parity concerns** -- whether UI actions have corresponding agent tools. That is the agent-native-reviewer's domain, not yours.
|
||||
- **Agent-native parity concerns** -- whether UI actions have corresponding agent tools. That is the ce-agent-native-reviewer's domain, not yours.
|
||||
- **Non-CLI code** -- web controllers, background jobs, library internals, or API endpoints that are not invoked as CLI commands.
|
||||
- **Framework choice itself** -- do not recommend switching from Click to Cobra or vice versa. Evaluate how well the chosen framework is used for agent readiness.
|
||||
- **Test files** -- test implementations of CLI commands are not the CLI surface itself.
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: code-simplicity-reviewer
|
||||
name: ce-code-simplicity-reviewer
|
||||
description: "Final review pass to ensure code is as simple and minimal as possible. Use after implementation is complete to identify YAGNI violations and simplification opportunities."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -34,7 +34,7 @@ When reviewing code, you will:
|
||||
- Eliminate extensibility points without clear use cases
|
||||
- Question generic solutions for specific problems
|
||||
- Remove "just in case" code
|
||||
- Never flag `docs/plans/*.md` or `docs/solutions/*.md` for removal — these are compound-engineering pipeline artifacts created by `/ce:plan` and used as living documents by `/ce:work`
|
||||
- Never flag `docs/plans/*.md` or `docs/solutions/*.md` for removal — these are compound-engineering pipeline artifacts created by `/ce-plan` and used as living documents by `/ce-work`
|
||||
|
||||
6. **Optimize for Readability**:
|
||||
- Prefer self-documenting code over comments
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: correctness-reviewer
|
||||
name: ce-correctness-reviewer
|
||||
description: Always-on code-review persona. Reviews code for logic errors, edge cases, state management bugs, error propagation failures, and intent-vs-implementation mismatches.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: data-integrity-guardian
|
||||
name: ce-data-integrity-guardian
|
||||
description: "Reviews database migrations, data models, and persistent data code for safety. Use when checking migration safety, data constraints, transaction boundaries, or privacy compliance."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: data-migration-expert
|
||||
name: ce-data-migration-expert
|
||||
description: "Validates data migrations, backfills, and production data transformations against reality. Use when PRs involve ID mappings, column renames, enum conversions, or schema changes."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: data-migrations-reviewer
|
||||
name: ce-data-migrations-reviewer
|
||||
description: Conditional code-review persona, selected when the diff touches migration files, schema changes, data transformations, or backfill scripts. Reviews code for data integrity and migration safety.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: deployment-verification-agent
|
||||
name: ce-deployment-verification-agent
|
||||
description: "Produces Go/No-Go deployment checklists with SQL verification queries, rollback procedures, and monitoring plans. Use when PRs touch production data, migrations, or risky data changes."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: dhh-rails-reviewer
|
||||
name: ce-dhh-rails-reviewer
|
||||
description: Conditional code-review persona, selected when Rails diffs introduce architectural choices, abstractions, or frontend patterns that may fight the framework. Reviews code from an opinionated DHH perspective.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: julik-frontend-races-reviewer
|
||||
name: ce-julik-frontend-races-reviewer
|
||||
description: Conditional code-review persona, selected when the diff touches async UI code, Stimulus/Turbo lifecycles, or DOM-timing-sensitive frontend behavior. Reviews code for race conditions and janky UI failure modes.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: kieran-python-reviewer
|
||||
name: ce-kieran-python-reviewer
|
||||
description: Conditional code-review persona, selected when the diff touches Python code. Reviews changes with Kieran's strict bar for Pythonic clarity, type hints, and maintainability.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: kieran-rails-reviewer
|
||||
name: ce-kieran-rails-reviewer
|
||||
description: Conditional code-review persona, selected when the diff touches Rails application code. Reviews Rails changes with Kieran's strict bar for clarity, conventions, and maintainability.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: kieran-typescript-reviewer
|
||||
name: ce-kieran-typescript-reviewer
|
||||
description: Conditional code-review persona, selected when the diff touches TypeScript code. Reviews changes with Kieran's strict bar for type safety, clarity, and maintainability.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: maintainability-reviewer
|
||||
name: ce-maintainability-reviewer
|
||||
description: Always-on code-review persona. Reviews code for premature abstraction, unnecessary indirection, dead code, coupling between unrelated modules, and naming that obscures intent.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: pattern-recognition-specialist
|
||||
name: ce-pattern-recognition-specialist
|
||||
description: "Analyzes code for design patterns, anti-patterns, naming conventions, and duplication. Use when checking codebase consistency or verifying new code follows established patterns."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: performance-oracle
|
||||
name: ce-performance-oracle
|
||||
description: "Analyzes code for performance bottlenecks, algorithmic complexity, database queries, memory usage, and scalability. Use after implementing features or when performance concerns arise."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: performance-reviewer
|
||||
name: ce-performance-reviewer
|
||||
description: Conditional code-review persona, selected when the diff touches database queries, loop-heavy data transforms, caching layers, or I/O-intensive paths. Reviews code for runtime performance and scalability issues.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: previous-comments-reviewer
|
||||
name: ce-previous-comments-reviewer
|
||||
description: Conditional code-review persona, selected when reviewing a PR that has existing review comments or review threads. Checks whether prior feedback has been addressed in the current diff.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: project-standards-reviewer
|
||||
name: ce-project-standards-reviewer
|
||||
description: Always-on code-review persona. Audits changes against the project's own CLAUDE.md and AGENTS.md standards -- frontmatter rules, reference inclusion, naming conventions, cross-platform portability, and tool selection policies.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -29,7 +29,7 @@ In either case, identify which sections apply to the file types in the diff. A s
|
||||
|
||||
- **Reference file inclusion mistakes** -- markdown links (`[file](./references/file.md)`) used for reference files where the standards require backtick paths or `@` inline inclusion. Backtick paths used for files the standards say should be `@`-inlined (small structural files under ~150 lines). `@` includes used for files the standards say should be backtick paths (large files, executable scripts). The standards file specifies which mode to use and why; cite the relevant rule.
|
||||
|
||||
- **Broken cross-references** -- agent names that are not fully qualified (e.g., `learnings-researcher` instead of `compound-engineering:research:learnings-researcher`). Skill-to-skill references using slash syntax inside a SKILL.md where the standards say to use semantic wording. References to tools by platform-specific names without naming the capability class.
|
||||
- **Broken cross-references** -- agent names that are not fully qualified (e.g., `ce-learnings-researcher` instead of `research:ce-learnings-researcher`). Skill-to-skill references using slash syntax inside a SKILL.md where the standards say to use semantic wording. References to tools by platform-specific names without naming the capability class.
|
||||
|
||||
- **Cross-platform portability violations** -- platform-specific tool names used without equivalents (e.g., `TodoWrite` instead of `TaskCreate`/`TaskUpdate`/`TaskList`). Slash references in pass-through SKILL.md files that won't be remapped. Assumptions about tool availability that break on other platforms.
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: reliability-reviewer
|
||||
name: ce-reliability-reviewer
|
||||
description: Conditional code-review persona, selected when the diff touches error handling, retries, circuit breakers, timeouts, health checks, background jobs, or async handlers. Reviews code for production reliability and failure modes.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: schema-drift-detector
|
||||
name: ce-schema-drift-detector
|
||||
description: "Detects unrelated schema.rb changes in PRs by cross-referencing against included migrations. Use when reviewing PRs with database schema changes."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -135,8 +135,8 @@ to regenerate schema with only PR-related changes.
|
||||
## Integration with Other Reviewers
|
||||
|
||||
This agent should be run BEFORE other database-related reviewers:
|
||||
- Run `schema-drift-detector` first to ensure clean schema
|
||||
- Then run `data-migration-expert` for migration logic review
|
||||
- Then run `data-integrity-guardian` for integrity checks
|
||||
- Run `ce-schema-drift-detector` first to ensure clean schema
|
||||
- Then run `ce-data-migration-expert` for migration logic review
|
||||
- Then run `ce-data-integrity-guardian` for integrity checks
|
||||
|
||||
Catching drift early prevents wasted review time on unrelated changes.
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: security-reviewer
|
||||
name: ce-security-reviewer
|
||||
description: Conditional code-review persona, selected when the diff touches auth middleware, public endpoints, user input handling, or permission checks. Reviews code for exploitable vulnerabilities.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: security-sentinel
|
||||
name: ce-security-sentinel
|
||||
description: "Performs security audits for vulnerabilities, input validation, auth/authz, hardcoded secrets, and OWASP compliance. Use when reviewing code for security issues or before deployment."
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
@@ -1,5 +1,5 @@
|
||||
---
|
||||
name: testing-reviewer
|
||||
name: ce-testing-reviewer
|
||||
description: Always-on code-review persona. Reviews code for test coverage gaps, weak assertions, brittle implementation-coupled tests, and missing edge case coverage.
|
||||
model: inherit
|
||||
tools: Read, Grep, Glob, Bash
|
||||
Reference in New Issue
Block a user