chore: mark review todos as complete
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
24
todos/003-complete-p2-test-toml-triple-quote.md
Normal file
24
todos/003-complete-p2-test-toml-triple-quote.md
Normal file
@@ -0,0 +1,24 @@
|
||||
---
|
||||
status: pending
|
||||
priority: p2
|
||||
issue_id: "003"
|
||||
tags: [code-review, testing, security]
|
||||
dependencies: []
|
||||
---
|
||||
|
||||
# Add test for TOML triple-quote escaping in prompt
|
||||
|
||||
## Problem Statement
|
||||
The `toToml` function escapes `"""` in prompts, but there is no test verifying this works correctly. This is a potential TOML injection vector.
|
||||
|
||||
## Findings
|
||||
- `src/converters/claude-to-gemini.ts` line 150: `prompt.replace(/"""/g, '\\"\\"\\"')`
|
||||
- `tests/gemini-converter.test.ts`: no triple-quote test in `toToml` describe block
|
||||
|
||||
## Proposed Solution
|
||||
Add a test in the `toToml` describe block that passes a prompt containing `"""` and verifies the output escapes it correctly.
|
||||
|
||||
## Acceptance Criteria
|
||||
- [ ] Test added for prompt containing `"""`
|
||||
- [ ] Escaped output does not prematurely close the TOML multi-line string
|
||||
- [ ] All tests pass
|
||||
Reference in New Issue
Block a user