chore: mark review todos as complete

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Kieran Klaassen
2026-02-14 20:46:53 -08:00
parent d487915f0f
commit 552ebceb0b
5 changed files with 121 additions and 0 deletions

View File

@@ -0,0 +1,24 @@
---
status: pending
priority: p2
issue_id: "002"
tags: [code-review, testing]
dependencies: []
---
# Add test for uniqueName dedup when agent collides with skill
## Problem Statement
The `uniqueName` function handles name collisions by appending `-2`, but there is no test covering the scenario where an agent name collides with a pass-through skill name.
## Findings
- `src/converters/claude-to-gemini.ts` lines 181-193: uniqueName function
- `tests/gemini-converter.test.ts`: no dedup test
## Proposed Solution
Add a test where a plugin has both a skill named "security-reviewer" and an agent named "Security Reviewer". The generated skill should get name "security-reviewer-2".
## Acceptance Criteria
- [ ] Test added for agent/skill name collision
- [ ] Test verifies the deduped name is `security-reviewer-2`
- [ ] All tests pass