john/claude-engineering-plugin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ce-demo-reel): two-stage upload for reviewable approval gate (#546)

Browse Source 
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Trevin Chow
2026-04-10 17:30:39 -07:00
committed by GitHub
parent fba5cbaa01
commit 545405380d
2 changed files with 143 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
plugins/compound-engineering/skills/ce-demo-reel/references/upload-and-approval.md
View File

@@ -1,40 +1,60 @@
# Upload and Approval
Get user approval for the local artifact, upload evidence to a public URL, and generate markdown for PR inclusion.
Upload a temporary preview for the user to review, then promote to permanent hosting on approval.
## Step 1: Local Approval Gate
## Step 1: Preview Upload (Temporary)
Before uploading anywhere public, present the local artifact path to the user for approval. Use the platform's blocking question tool (`AskUserQuestion` in Claude Code, `request_user_input` in Codex, `ask_user` in Gemini).
**Question:** "Evidence captured at [RUN_DIR]/[artifact]. Review it locally and decide:"
**Options:**
1. **Looks good, upload for PR** -- proceed to upload
2. **Not good enough, try again** -- return to the tier execution step and re-capture
3. **Skip evidence for this PR** -- set evidence to null and proceed
If the question tool is unavailable (headless/background mode), present the numbered options and wait for the user's reply before proceeding.
## Step 2: Upload to catbox.moe
After the user approves the local artifact, upload the evidence file (GIF or PNG) using the capture pipeline script. Set `ARTIFACT_PATH` to the approved GIF or PNG path:
Upload the evidence file (GIF or PNG) to litterbox for a temporary 1-hour preview:
```bash
python3 scripts/capture-demo.py upload [ARTIFACT_PATH]
python3 scripts/capture-demo.py preview [ARTIFACT_PATH]
```
The script uploads to catbox.moe, validates the response starts with `https://`, and retries once on failure. The last line of output is the public URL (e.g., `https://files.catbox.moe/abc123.gif`).
**If upload fails** after retry, report the failure and the local artifact path. Do not commit evidence files to the repo — they are ephemeral artifacts, not source material. Tell the user: "Upload failed. Local artifact preserved at [ARTIFACT_PATH]. You can upload it manually or retry later."
The last line of output is the preview URL (e.g., `https://litter.catbox.moe/abc123.gif`). This URL expires after 1 hour — no cleanup needed.
For multiple files (static screenshots tier), upload each file separately.
## Step 3: Return Output
**If upload fails** after retry, fall back to opening the local file with the platform file-opener (`open` on macOS, `xdg-open` on Linux) so the user can still review it. Include the local path in the approval question instead of a URL.
Return the structured output defined in the SKILL.md Output section: `Tier`, `Description`, and `URL`. The caller formats the evidence into the PR description. ce-demo-reel does not generate markdown.
## Step 2: Approval Gate
## Step 4: Cleanup
Present the preview URL to the user for approval. Use the platform's blocking question tool (`AskUserQuestion` in Claude Code, `request_user_input` in Codex, `ask_user` in Gemini).
Remove the `[RUN_DIR]` scratch directory and all temporary files. Preserve nothing -- the evidence lives at the public URL now.
**Question:** "Evidence preview (1h link): [PREVIEW_URL]"
If the upload failed and the user has not yet manually uploaded, preserve `[RUN_DIR]` so the artifact is still accessible.
**Options:**
1. **Use this in the PR** -- promote to permanent hosting
2. **Recapture** -- provide instructions on what to change
3. **Proceed without evidence** -- set evidence to null and proceed
If the question tool is unavailable (headless/background mode), present the numbered options and wait for the user's reply before proceeding.
### On "Recapture"
Return to the tier execution step. The user's instructions guide what to change in the next capture attempt. After recapture, upload a new preview and repeat the approval gate.
### On "Proceed without evidence"
Set evidence to null and proceed. The preview link expires on its own.
## Step 3: Promote to Permanent Hosting
After the user approves, upload to permanent catbox hosting. The command accepts either the preview URL (preferred) or the local file path (fallback):
```bash
python3 scripts/capture-demo.py upload [PREVIEW_URL or ARTIFACT_PATH]
```
If Step 1 produced a preview URL, pass it here -- catbox copies directly from litterbox without re-uploading. If Step 1 fell back to local review (no preview URL), pass the local artifact path instead.
The last line of output is the permanent URL (e.g., `https://files.catbox.moe/abc123.gif`). Use this URL in the output, not the preview URL.
For multiple files, promote each separately.
## Step 4: Return Output
Return the structured output defined in the SKILL.md Output section: `Tier`, `Description`, and `URL` (the permanent catbox URL). The caller formats the evidence into the PR description. ce-demo-reel does not generate markdown.
## Step 5: Cleanup
Remove the `[RUN_DIR]` scratch directory and all temporary files. Preserve nothing -- the evidence lives at the permanent URL now.