Merge step (e): port ce-review content into ce-code-review
Some checks failed
CI / pr-title (push) Has been cancelled
CI / test (push) Has been cancelled
Release PR / release-pr (push) Has been cancelled
Release PR / publish-cli (push) Has been cancelled

Applies triage doc 020 — moves local ce-review/* modifications into upstream's
renamed ce-code-review/ skill.

- persona-catalog.md: rebase to local's richer 21-persona catalog (4
  always-on + 8 conditional + 4 stack-specific + 5 language/framework)
  plus 4 CE conditional agents. Rename all agent refs from
  compound-engineering:review:<name> to ce-<name>. Keep upstream's swift-ios
  persona. Drop rails personas (local deleted those reviewers).
- SKILL.md: add ce-design-conformance-reviewer, ce-zip-agent-validator, and
  ce-tiangolo-fastapi-reviewer to the conditional team; add Zip Agent
  Validation section as Stage 6 item 11; update dispatch context and
  artifact preservation notes for the new CE conditional agents.
- review-output-template.md: add Zip Agent Validation example section
  between Deployment Notes and Coverage, plus formatting-rule entry.
- Delete ce-review/ directory (content fully ported).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
John Lamb
2026-04-24 13:58:25 -05:00
parent 8fb78d1378
commit 4d4586d4a8
5 changed files with 50 additions and 938 deletions

View File

@@ -77,6 +77,15 @@ Use this **exact format** when presenting synthesized review findings. Findings
- Verify: `SELECT COUNT(*) FROM exports WHERE status IS NULL;` should stay at `0`
- Rollback: keep the old export path available until the backfill has been validated
### Zip Agent Validation
- Evaluated: 8 zip-agent comments
- Validated: 2 (appear as findings #3 and #6 above)
- Collapsed: 6
- `app/services/order_service.rb:45`: "Missing error handling" -- handled by ApplicationService base class rescue
- `app/controllers/api/orders_controller.rb:18`: "Unbounded query" -- pagination enforced by ApiController concern
- _(4 more collapsed for stylistic/formatting concerns)_
### Coverage
- Suppressed: 2 findings below anchor 75 (1 at anchor 50, 1 at anchor 25)
@@ -130,6 +139,7 @@ This fails because: no pipe-delimited tables, no severity-grouped `###` headers,
- **Agent-Native Gaps section** -- results from ce-agent-native-reviewer. Omit if no gaps found.
- **Schema Drift Check section** -- results from ce-schema-drift-detector. Omit if the agent did not run.
- **Deployment Notes section** -- key checklist items from ce-deployment-verification-agent. Omit if the agent did not run.
- **Zip Agent Validation section** -- summary of ce-zip-agent-validator evaluation. Omit if the agent did not run.
- **Coverage section** -- suppressed count, residual risks, testing gaps, failed reviewers
- **Summary uses blockquotes** for verdict, reasoning, and fix order
- **Horizontal rule** (`---`) separates findings from verdict