Merge step (e): port ce-review content into ce-code-review

Applies triage doc 020 — moves local ce-review/* modifications into upstream's
renamed ce-code-review/ skill.

- persona-catalog.md: rebase to local's richer 21-persona catalog (4
  always-on + 8 conditional + 4 stack-specific + 5 language/framework)
  plus 4 CE conditional agents. Rename all agent refs from
  compound-engineering:review:<name> to ce-<name>. Keep upstream's swift-ios
  persona. Drop rails personas (local deleted those reviewers).
- SKILL.md: add ce-design-conformance-reviewer, ce-zip-agent-validator, and
  ce-tiangolo-fastapi-reviewer to the conditional team; add Zip Agent
  Validation section as Stage 6 item 11; update dispatch context and
  artifact preservation notes for the new CE conditional agents.
- review-output-template.md: add Zip Agent Validation example section
  between Deployment Notes and Coverage, plus formatting-rule entry.
- Delete ce-review/ directory (content fully ported).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

plugins/compound-engineering/skills/ce-code-review/SKILL.md

@@ -137,18 +137,20 @@ Routing rules:
 | Agent | Select when diff touches... |
 |-------|---------------------------|
 | `ce-dhh-rails-reviewer` | Rails architecture, service objects, session/auth choices, or Hotwire-vs-SPA boundaries |
-| `ce-kieran-rails-reviewer` | Rails application code where conventions, naming, and maintainability are in play |
 | `ce-kieran-python-reviewer` | Python modules, endpoints, scripts, or services |
 | `ce-kieran-typescript-reviewer` | TypeScript components, services, hooks, utilities, or shared types |
 | `ce-julik-frontend-races-reviewer` | Stimulus/Turbo controllers, DOM events, timers, animations, or async UI flows |
 | `ce-swift-ios-reviewer` | Swift files, SwiftUI views, UIKit controllers, entitlements, privacy manifests, Core Data models, SPM manifests, storyboards/XIBs, or semantic build-setting/target/signing changes in .pbxproj |
+| `ce-tiangolo-fastapi-reviewer` | FastAPI application code, dependency injection, response models, middleware, OpenAPI schemas |
 
-**CE conditional (migration-specific):**
+**CE conditional (design, migration & external review):**
 
-| Agent | Select when diff includes migration files |
-|-------|------------------------------------------|
-| `ce-schema-drift-detector` | Cross-references schema.rb against included migrations |
-| `ce-deployment-verification-agent` | Produces deployment checklist with SQL verification queries |
+| Agent | Select when... |
+|-------|----------------|
+| `ce-design-conformance-reviewer` | Repo contains design documents or an active plan matching the current branch |
+| `ce-schema-drift-detector` | Diff includes migration files -- cross-references schema.rb against included migrations |
+| `ce-deployment-verification-agent` | Diff includes migration files -- produces deployment checklist with SQL verification queries |
+| `ce-zip-agent-validator` | PR URL contains `git.zoominfo.com` -- pressure-tests zip-agent comments for validity |
 
 ## Review Scope
 
@@ -366,7 +368,7 @@ Read the diff and file list from Stage 1. The 4 always-on personas and 2 CE alwa
 
 Stack-specific personas are additive. A Rails UI change may warrant `kieran-rails` plus `julik-frontend-races`; a TypeScript API diff may warrant `kieran-typescript` plus `api-contract` and `reliability`.
 
-For CE conditional agents, check if the diff includes files matching `db/migrate/*.rb`, `db/schema.rb`, or data backfill scripts.
+For CE conditional agents, check if the diff includes files matching `db/migrate/*.rb`, `db/schema.rb`, or data backfill scripts. If the repo contains design documents (`docs/`, `docs/design/`, `docs/architecture/`, `docs/specs/`) or an active plan matching the current branch, select `ce-design-conformance-reviewer`. If the PR URL contains `git.zoominfo.com`, select `ce-zip-agent-validator`.
 
 Announce the team before spawning:
 
@@ -465,7 +467,7 @@ Detail-tier fields (`why_it_matters`, `evidence`) are in the artifact file only.
 
 **CE always-on agents** (ce-agent-native-reviewer, ce-learnings-researcher) are dispatched as standard Agent calls in parallel with the persona agents. Give them the same review context bundle the personas receive: entry mode, any PR metadata gathered in Stage 1, intent summary, review base branch name when known, `BASE:` marker, file list, diff, and `UNTRACKED:` scope notes. Do not invoke them with a generic "review this" prompt. Their output is unstructured and synthesized separately in Stage 6.
 
-**CE conditional agents** (ce-schema-drift-detector, ce-deployment-verification-agent) are also dispatched as standard Agent calls when applicable. Pass the same review context bundle plus the applicability reason (for example, which migration files triggered the agent). For ce-schema-drift-detector specifically, pass the resolved review base branch explicitly so it never assumes `main`. Their output is unstructured and must be preserved for Stage 6 synthesis just like the CE always-on agents.
+**CE conditional agents** (ce-design-conformance-reviewer, ce-schema-drift-detector, ce-deployment-verification-agent, ce-zip-agent-validator) are also dispatched as standard Agent calls when applicable. Pass the same review context bundle plus the applicability reason (for example, which migration files triggered the agent, which design docs were found, or that the PR URL matched `git.zoominfo.com`). For ce-schema-drift-detector specifically, pass the resolved review base branch explicitly so it never assumes `main`. For ce-zip-agent-validator, pass the full PR URL and the PR number so it can fetch comments from the GHE API. Their output is unstructured and must be preserved for Stage 6 synthesis just like the CE always-on agents.
 
 ### Stage 5: Merge findings
 
@@ -510,7 +512,7 @@ Demotion is intentionally narrow. The conservative scope (testing/maintainabilit
    - report-only queue: `advisory` findings plus anything owned by `human` or `release`
 9. **Sort.** Order by severity (P0 first) -> anchor (descending) -> file path -> line number.
 10. **Collect coverage data.** Union residual_risks and testing_gaps across reviewers.
-11. **Preserve CE agent artifacts.** Keep the learnings, agent-native, schema-drift, and deployment-verification outputs alongside the merged finding set. Do not drop unstructured agent output just because it does not match the persona JSON schema.
+11. **Preserve CE agent artifacts.** Keep the learnings, agent-native, design-conformance, schema-drift, deployment-verification, and zip-agent-validator outputs alongside the merged finding set. Do not drop unstructured agent output just because it does not match the persona JSON schema. For ce-zip-agent-validator specifically, its validated findings use the standard findings schema and enter the merge pipeline (steps 1-7) like persona findings. Its `residual_risks` entries (collapsed zip-agent comments) are preserved separately for the Zip Agent Validation section in Stage 6.
 
 ### Stage 5b: Validation pass (externalizing modes only)
 
@@ -569,8 +571,9 @@ Assemble the final report using **pipe-delimited markdown tables for findings**
 8. **Agent-Native Gaps.** Surface ce-agent-native-reviewer results. Omit section if no gaps found.
 9. **Schema Drift Check.** If ce-schema-drift-detector ran, summarize whether drift was found. If drift exists, list the unrelated schema objects and the required cleanup command. If clean, say so briefly.
 10. **Deployment Notes.** If ce-deployment-verification-agent ran, surface the key Go/No-Go items: blocking pre-deploy checks, the most important verification queries, rollback caveats, and monitoring focus areas. Keep the checklist actionable rather than dropping it into Coverage.
-11. **Coverage.** Suppressed count by anchor (e.g., "N findings suppressed at anchor 50, M at anchor 25"), mode-aware demotion count (interactive/report-only) or suppression count (headless/autofix), validator drop count and reasons (when Stage 5b ran), validator over-budget drops (when the 15-cap fired), residual risks, testing gaps, failed/timed-out reviewers, and any intent uncertainty carried by non-interactive modes.
-12. **Verdict.** Ready to merge / Ready with fixes / Not ready. Fix order if applicable. When an `explicit` plan has unaddressed requirements, the verdict must reflect it — a PR that's code-clean but missing planned requirements is "Not ready" unless the omission is intentional. When an `inferred` plan has unaddressed requirements, note it in the verdict reasoning but do not block on it alone.
+11. **Zip Agent Validation.** If ce-zip-agent-validator ran, summarize the results: how many zip-agent comments were evaluated, how many validated (these appear as findings in the severity-grouped tables above), and how many collapsed with reasons. This section provides traceability -- reviewers can see that zip-agent comments were evaluated, not ignored.
+12. **Coverage.** Suppressed count by anchor (e.g., "N findings suppressed at anchor 50, M at anchor 25"), mode-aware demotion count (interactive/report-only) or suppression count (headless/autofix), validator drop count and reasons (when Stage 5b ran), validator over-budget drops (when the 15-cap fired), residual risks, testing gaps, failed/timed-out reviewers, and any intent uncertainty carried by non-interactive modes.
+13. **Verdict.** Ready to merge / Ready with fixes / Not ready. Fix order if applicable. When an `explicit` plan has unaddressed requirements, the verdict must reflect it — a PR that's code-clean but missing planned requirements is "Not ready" unless the omission is intentional. When an `inferred` plan has unaddressed requirements, note it in the verdict reasoning but do not block on it alone.
 
 Do not include time estimates.
 

plugins/compound-engineering/skills/ce-code-review/references/persona-catalog.md

@@ -1,6 +1,6 @@
 # Persona Catalog
 
-18 reviewer personas organized into always-on, cross-cutting conditional, and stack-specific conditional layers, plus CE-specific agents. The orchestrator uses this catalog to select which reviewers to spawn for each review.
+21 reviewer personas organized into always-on, cross-cutting conditional, stack-specific conditional, and language/framework conditional layers, plus CE-specific agents. The orchestrator uses this catalog to select which reviewers to spawn for each review.
 
 ## Always-on (4 personas + 2 CE agents)
 
@@ -33,36 +33,49 @@ Spawned when the orchestrator identifies relevant patterns in the diff. The orch
 | `api-contract` | `ce-api-contract-reviewer` | Route definitions, serializer/interface changes, event schemas, exported type signatures, API versioning |
 | `data-migrations` | `ce-data-migrations-reviewer` | Migration files, schema changes, backfill scripts, data transformations |
 | `reliability` | `ce-reliability-reviewer` | Error handling, retry logic, circuit breakers, timeouts, background jobs, async handlers, health checks |
-| `adversarial` | `ce-adversarial-reviewer` | Diff has >=50 changed non-test, non-generated, non-lockfile lines, OR touches auth, payments, data mutations, external API integrations, or other high-risk domains |
+| `adversarial` | `ce-adversarial-reviewer` | Diff has >=50 changed lines of executable code (not prose/instruction Markdown, JSON schemas, or config), OR touches auth, payments, data mutations, external API integrations, or other high-risk domains regardless of file type |
 | `cli-readiness` | `ce-cli-readiness-reviewer` | CLI command definitions, argument parsing, CLI framework usage, command handler implementations |
 | `previous-comments` | `ce-previous-comments-reviewer` | **PR-only.** Reviewing a PR that has existing review comments or review threads from prior review rounds. Skip entirely when no PR metadata was gathered in Stage 1. |
 
-## Stack-Specific Conditional (6 personas)
+## Stack-Specific Conditional (4 personas)
 
 These reviewers keep their original opinionated lens. They are additive with the cross-cutting personas above, not replacements for them.
 
 | Persona | Agent | Select when diff touches... |
 |---------|-------|---------------------------|
-| `dhh-rails` | `ce-dhh-rails-reviewer` | Rails architecture, service objects, authentication/session choices, Hotwire-vs-SPA boundaries, or abstractions that may fight Rails conventions |
-| `kieran-rails` | `ce-kieran-rails-reviewer` | Rails controllers, models, views, jobs, components, routes, or other application-layer Ruby code where clarity and conventions matter |
 | `kieran-python` | `ce-kieran-python-reviewer` | Python modules, endpoints, services, scripts, or typed domain code |
 | `kieran-typescript` | `ce-kieran-typescript-reviewer` | TypeScript components, services, hooks, utilities, or shared types |
 | `julik-frontend-races` | `ce-julik-frontend-races-reviewer` | Stimulus/Turbo controllers, DOM event wiring, timers, async UI flows, animations, or frontend state transitions with race potential |
 | `swift-ios` | `ce-swift-ios-reviewer` | Swift files, SwiftUI views, UIKit controllers, `.entitlements`, `PrivacyInfo.xcprivacy`, `.xcdatamodeld`, `Package.swift`, `Package.resolved`, storyboards, XIBs, or semantic build-setting / target-membership / code-signing changes in `.pbxproj` |
 
-## CE Conditional Agents (migration-specific)
+## Language & Framework Conditional (5 personas)
 
-These CE-native agents provide specialized analysis beyond what the persona agents cover. Spawn them when the diff includes database migrations, schema.rb, or data backfills.
+Spawned when the orchestrator identifies language or framework-specific patterns in the diff. These provide deeper domain expertise than the general-purpose personas above.
 
-| Agent | Focus |
-|-------|-------|
-| `ce-schema-drift-detector` | Cross-references schema.rb changes against included migrations to catch unrelated drift |
-| `ce-deployment-verification-agent` | Produces Go/No-Go deployment checklist with SQL verification queries and rollback procedures |
+| Persona | Agent | Select when diff touches... |
+|---------|-------|---------------------------|
+| `python-quality` | `ce-kieran-python-reviewer` | Python files, FastAPI routes, Pydantic models, async/await patterns, SQLAlchemy usage |
+| `fastapi-philosophy` | `ce-tiangolo-fastapi-reviewer` | FastAPI application code, dependency injection, response models, middleware, OpenAPI schemas |
+| `typescript-quality` | `ce-kieran-typescript-reviewer` | TypeScript files, React components, type definitions, generic patterns |
+| `frontend-races` | `ce-julik-frontend-races-reviewer` | Frontend JavaScript, Stimulus controllers, event listeners, async UI code, animations, DOM lifecycle |
+| `architecture` | `ce-architecture-strategist` | New services, module boundaries, dependency graphs, API layer changes, package structure |
+
+## CE Conditional Agents (design, migration & external review)
+
+These CE-native agents provide specialized analysis beyond what the persona agents cover. Spawn them when the diff includes database migrations, schema.rb, data backfills, design documents, or when the PR originates from specific platforms.
+
+| Agent | Focus | Select when... |
+|-------|-------|----------------|
+| `ce-design-conformance-reviewer` | Surfaces deviations between the diff and the repo's design docs or implementation plan | The repo contains design documents (`docs/`, `docs/design/`, `docs/architecture/`, `docs/specs/`) or an active plan matching the current branch |
+| `ce-schema-drift-detector` | Cross-references schema.rb changes against included migrations to catch unrelated drift | The diff includes migration files or schema.rb |
+| `ce-deployment-verification-agent` | Produces Go/No-Go deployment checklist with SQL verification queries and rollback procedures | The diff includes migration files, schema.rb, or data backfills |
+| `ce-zip-agent-validator` | Pressure-tests zip-agent review comments for validity against full codebase context | The PR URL contains `git.zoominfo.com` |
 
 ## Selection rules
 
 1. **Always spawn all 4 always-on personas** plus the 2 CE always-on agents.
 2. **For each cross-cutting conditional persona**, the orchestrator reads the diff and decides whether the persona's domain is relevant. This is a judgment call, not a keyword match.
 3. **For each stack-specific conditional persona**, use file types and changed patterns as a starting point, then decide whether the diff actually introduces meaningful work for that reviewer. Do not spawn language-specific reviewers just because one config or generated file happens to match the extension.
-4. **For CE conditional agents**, spawn when the diff includes migration files (`db/migrate/*.rb`, `db/schema.rb`) or data backfill scripts.
-5. **Announce the team** before spawning with a one-line justification per conditional reviewer selected.
+4. **For each language/framework conditional persona**, check whether the diff touches language or framework-specific patterns that warrant deeper domain expertise. These are additive with stack-specific personas, not replacements.
+5. **For CE conditional agents**, spawn when applicable: migration files (`db/migrate/*.rb`, `db/schema.rb`) or data backfill scripts trigger ce-schema-drift-detector and ce-deployment-verification-agent; design documents or active plans trigger ce-design-conformance-reviewer; PR URLs containing `git.zoominfo.com` trigger ce-zip-agent-validator.
+6. **Announce the team** before spawning with a one-line justification per conditional reviewer selected.

plugins/compound-engineering/skills/ce-code-review/references/review-output-template.md

@@ -77,6 +77,15 @@ Use this **exact format** when presenting synthesized review findings. Findings
 - Verify: `SELECT COUNT(*) FROM exports WHERE status IS NULL;` should stay at `0`
 - Rollback: keep the old export path available until the backfill has been validated
 
+### Zip Agent Validation
+
+- Evaluated: 8 zip-agent comments
+- Validated: 2 (appear as findings #3 and #6 above)
+- Collapsed: 6
+  - `app/services/order_service.rb:45`: "Missing error handling" -- handled by ApplicationService base class rescue
+  - `app/controllers/api/orders_controller.rb:18`: "Unbounded query" -- pagination enforced by ApiController concern
+  - _(4 more collapsed for stylistic/formatting concerns)_
+
 ### Coverage
 
 - Suppressed: 2 findings below anchor 75 (1 at anchor 50, 1 at anchor 25)
@@ -130,6 +139,7 @@ This fails because: no pipe-delimited tables, no severity-grouped `###` headers,
 - **Agent-Native Gaps section** -- results from ce-agent-native-reviewer. Omit if no gaps found.
 - **Schema Drift Check section** -- results from ce-schema-drift-detector. Omit if the agent did not run.
 - **Deployment Notes section** -- key checklist items from ce-deployment-verification-agent. Omit if the agent did not run.
+- **Zip Agent Validation section** -- summary of ce-zip-agent-validator evaluation. Omit if the agent did not run.
 - **Coverage section** -- suppressed count, residual risks, testing gaps, failed reviewers
 - **Summary uses blockquotes** for verdict, reasoning, and fix order
 - **Horizontal rule** (`---`) separates findings from verdict