From 178d6ec282512eaee71ab66d45832d22d75353ec Mon Sep 17 00:00:00 2001 From: Trevin Chow Date: Wed, 18 Mar 2026 02:02:30 -0700 Subject: [PATCH] fix: remove close-stale-PR step that broke release creation Closing the release PR before release-please runs prevented release-please from recognizing the PR on merge, so it never created GitHub Releases or tags. The close-reopen approach is incompatible with release-please's PR tracking. Keep cancel-in-progress: true for rapid-succession merges and the release-merge detection for skipping validate. Accept that the PR body may be stale -- GitHub Releases get correct changelogs at merge time regardless. --- .github/workflows/release-pr.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/release-pr.yml b/.github/workflows/release-pr.yml index 3308ae7..820baff 100644 --- a/.github/workflows/release-pr.yml +++ b/.github/workflows/release-pr.yml @@ -48,17 +48,6 @@ jobs: if: steps.detect.outputs.is_release_merge == 'false' run: bun run release:validate - - name: Close stale release PR - if: steps.detect.outputs.is_release_merge == 'false' - run: | - PR=$(gh pr list --head release-please--branches--main --json number --jq '.[0].number') - if [ -n "$PR" ]; then - echo "Closing stale release PR #$PR so release-please regenerates with full changelog" - gh pr close "$PR" --delete-branch=false - fi - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Maintain release PR id: release uses: googleapis/release-please-action@v4.4.0